Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomplate: init at 3.6.0 #85157

Closed
wants to merge 1 commit into from
Closed

gomplate: init at 3.6.0 #85157

wants to merge 1 commit into from

Conversation

@jlesquembre
Copy link
Contributor

@jlesquembre jlesquembre commented Apr 13, 2020

Motivation for this change

Add gomplate

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
-X ${goPackagePath}/v3/version.GitCommit=${rev}")
'';

goPackagePath = "github.com/hairyhenderson/gomplate";

This comment has been minimized.

@doronbehar

doronbehar Apr 13, 2020
Contributor

Suggested change
goPackagePath = "github.com/hairyhenderson/gomplate";

This is relevant only for buildGoPackage.

This comment has been minimized.

@jlesquembre

jlesquembre Apr 13, 2020
Author Contributor

True, but I'm using it on the buildFlagsArray. I could change the variable name if that makes the intention clearer.

This comment has been minimized.

@doronbehar

doronbehar Apr 13, 2020
Contributor

Then I guess it's not that important, keep it that way.

-X ${goPackagePath}/v3/version.GitCommit=${rev}")
'';

goPackagePath = "github.com/hairyhenderson/gomplate";

This comment has been minimized.

@doronbehar

doronbehar Apr 13, 2020
Contributor

Then I guess it's not that important, keep it that way.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented May 15, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/162

@risicle risicle mentioned this pull request Oct 2, 2020
5 of 10 tasks complete
@06kellyjac
Copy link
Contributor

@06kellyjac 06kellyjac commented Oct 4, 2020

Since #99402 is merged this can be closed now

@doronbehar doronbehar closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.