Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/unit: update service configuration and update unit to 1.17 #85225

Merged
merged 7 commits into from May 6, 2020

Conversation

@Izorkin
Copy link
Contributor

Izorkin commented Apr 14, 2020

Motivation for this change

Fixed startup service.
Update sandboxing mode - change to "strict" mode and add option to allow writing to custom directories
Running Unit from root - in latest release recommended not set ambient capabilities.
Add simple unit-php test.
Update unit to 1.17

cc @Mic92 @flokli @aanderse

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Izorkin Izorkin force-pushed the Izorkin:nginx-unit branch 2 times, most recently from d4df835 to f97ddfc Apr 14, 2020
@Izorkin Izorkin force-pushed the Izorkin:nginx-unit branch 3 times, most recently from 749a877 to c069019 Apr 15, 2020
@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 16, 2020

Added unit-php test.
@aanderse @etu please recheck.

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 16, 2020

@GrahamcOfBorg test php.unit

@Izorkin Izorkin force-pushed the Izorkin:nginx-unit branch from c069019 to f8e81fe Apr 16, 2020
@Izorkin Izorkin changed the title nixos/unit: update service configuration nixos/unit: update service configuration and update unit to 1.17 Apr 16, 2020
@Izorkin Izorkin requested a review from aanderse Apr 18, 2020
@Izorkin Izorkin force-pushed the Izorkin:nginx-unit branch from f8e81fe to a1ccd04 Apr 20, 2020
@Izorkin Izorkin force-pushed the Izorkin:nginx-unit branch 3 times, most recently from 4c8437a to 79d8fdc Apr 22, 2020
@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 23, 2020

@GrahamcOfBorg test php.unit

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 23, 2020

nixos/tests/php/default.nix Outdated Show resolved Hide resolved
nixos/tests/php/unit.nix Outdated Show resolved Hide resolved
nixos/tests/php/unit.nix Outdated Show resolved Hide resolved
@Izorkin Izorkin force-pushed the Izorkin:nginx-unit branch 3 times, most recently from b441f21 to 6b140c6 Apr 24, 2020
@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 24, 2020

@GrahamcOfBorg test unit-php

@Izorkin Izorkin requested a review from etu Apr 27, 2020
@Izorkin Izorkin force-pushed the Izorkin:nginx-unit branch from 6b140c6 to 3b2048d Apr 29, 2020
@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 29, 2020

Fixed conflicting files

@Izorkin Izorkin force-pushed the Izorkin:nginx-unit branch 3 times, most recently from 99e3410 to 5853ccb Apr 30, 2020
@Izorkin Izorkin force-pushed the Izorkin:nginx-unit branch from 5853ccb to 168de86 May 6, 2020
@Izorkin Izorkin force-pushed the Izorkin:nginx-unit branch from 168de86 to ca2145b May 6, 2020
@Mic92
Copy link
Contributor

Mic92 commented May 6, 2020

Result of nixpkgs-review pr 85225 1

1 package built:
- unit
@Mic92 Mic92 merged commit 5487e15 into NixOS:master May 6, 2020
11 of 13 checks passed
11 of 13 checks passed
grahamcofborg-eval Calculating Changed Outputs
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ca2145b"; rev="ca2145bdfc83382ba7ec83a275734040a2a7fddc"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ca2145b"; rev="ca2145bdfc83382ba7ec83a275734040a2a7fddc"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ca2145b"; rev="ca2145bdfc83382ba7ec83a275734040a2a7fddc"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ca2145b"; rev="ca2145bdfc83382ba7ec83a275734040a2a7fddc"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ca2145b"; rev="ca2145bdfc83382ba7ec83a275734040a2a7fddc"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ca2145b"; rev="ca2145bdfc83382ba7ec83a275734040a2a7fddc"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ca2145b"; rev="ca2145bdfc83382ba7ec83a275734040a2a7fddc"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Izorkin Izorkin deleted the Izorkin:nginx-unit branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.