Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-analyzer: 2020-04-06 -> 2020-04-20 #85243

Merged
merged 2 commits into from Apr 23, 2020
Merged

rust-analyzer: 2020-04-06 -> 2020-04-20 #85243

merged 2 commits into from Apr 23, 2020

Conversation

@oxalica
Copy link
Contributor

oxalica commented Apr 14, 2020

Motivation for this change

Bump rust-analyzer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

jonringer left a comment

the changes to pkgs/development/node-packages/node-packages-v12.nix are not really needed

@HugoReeves
Copy link
Contributor

HugoReeves commented Apr 14, 2020

Thanks for packaging rust-analyzer!
Was able to build and execute on NixOS and MacOS Catalina.

I'm not involved with any of these packages, but, I believe removing quotes around the URLs in nodePackages is probably not a good idea. I think I read somewhere that future versions of the Nix language might look to remove the special syntax for URLs, so keeping the URLs in quotes is probably a good idea.

You're also changing a package which isn't really associated with rust-analyzer, so if you want to make the edits to nodePackages they should probably get their own PR.
Just my thoughts, thanks again.

@oxalica
Copy link
Contributor Author

oxalica commented Apr 15, 2020

@jonringer
Actually yes, but the generator updates all of them. Only node-packages-v10.nix is used by vscode-extensions.rust-analyzer and should be updated.
So should I only update v10 packages here?

@oxalica
Copy link
Contributor Author

oxalica commented Apr 21, 2020

2020-04-20 is released, but blocked by #85618.

oxalica added 2 commits Apr 23, 2020
@oxalica oxalica force-pushed the oxalica:rust-analyzer branch from aadab93 to b956999 Apr 23, 2020
@oxalica oxalica changed the title rust-analyzer: 2020-04-06 -> 2020-04-13 rust-analyzer: 2020-04-06 -> 2020-04-20 Apr 23, 2020
@oxalica oxalica requested a review from jonringer Apr 23, 2020
@oxalica
Copy link
Contributor Author

oxalica commented Apr 23, 2020

@jonringer Bumped to 2020-04-20 and upgrade only node-packages-v10.nix now.

@Mic92 Mic92 merged commit 11019ea into NixOS:master Apr 23, 2020
15 of 16 checks passed
15 of 16 checks passed
rust-analyzer, rust-analyzer.passthru.tests on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b956999"; rev="b95699970fb7d825fd4a710f5cfa3785a98435db"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b956999"; rev="b95699970fb7d825fd4a710f5cfa3785a98435db"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b956999"; rev="b95699970fb7d825fd4a710f5cfa3785a98435db"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b956999"; rev="b95699970fb7d825fd4a710f5cfa3785a98435db"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b956999"; rev="b95699970fb7d825fd4a710f5cfa3785a98435db"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b956999"; rev="b95699970fb7d825fd4a710f5cfa3785a98435db"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b956999"; rev="b95699970fb7d825fd4a710f5cfa3785a98435db"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
rust-analyzer, rust-analyzer.passthru.tests on aarch64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.