Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
containerd: fix --version output #85269
Before this change, 'containerd --version' with the nix package wouldn't
In addition, the build output a bunch of (harmless) errors about 'git:
This fixes those problems.
Here's the difference from this change:
vdemeester left a comment
Oh, it turns out I was blind; for some reason I mis-remembered that overriding some makefile variables would prevent the assignment from being evaluating, but others it wouldn't.
It turns out that's wrong, and I can just set
Well, that makes this PR much simpler. One second ...
Before this change, 'containerd --version' with the nix package wouldn't print useful version information. In addition, the build output a bunch of (harmless) errors about 'git: command not found'. This fixes both of those problems.