Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php.extensions.sqlsrv: 5.8.0 -> 5.8.1 #85319

Merged
merged 2 commits into from May 3, 2020
Merged

php.extensions.sqlsrv: 5.8.0 -> 5.8.1 #85319

merged 2 commits into from May 3, 2020

Conversation

@aanderse
Copy link
Contributor

aanderse commented Apr 15, 2020

Motivation for this change

https://github.com/microsoft/msphpsql/releases/tag/v5.8.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@aanderse
Copy link
Contributor Author

aanderse commented Apr 15, 2020

@etu @talyz I'm having a little issue with this one... any ideas?

~/nixpkgs> nix-build -E 'with import ~/nixpkgs {}; php.withExtensions (e: [ e.pdo_sqlsrv ])'                                                                                                        
error: attribute 'pdo' missing, at /home/aaron/nixpkgs/lib/strings-with-deps.nix:67:71
(use '--show-trace' to show detailed location information)
@etu
Copy link
Contributor

etu commented Apr 15, 2020

pdo_sqlsrv needs the pdo extension, so php refuse to build it without it 🙂

Try:

nix-build -E 'with import ~/nixpkgs {}; php.withExtensions (e: [ e.pdo e.pdo_sqlsrv ])'
@aanderse
Copy link
Contributor Author

aanderse commented Apr 15, 2020

Verified pdo_sqlsrv works with php72, php73, and php74 by executing a simple php script to hit a database.

@aanderse aanderse marked this pull request as ready for review Apr 15, 2020
@aanderse aanderse requested a review from etu as a code owner Apr 15, 2020
@aanderse
Copy link
Contributor Author

aanderse commented Apr 15, 2020

@GrahamcOfBorg build php72.extensions.pdo_sqlsrv php73.extensions.pdo_sqlsrv php74.extensions.pdo_sqlsrv
@GrahamcOfBorg build php72.extensions.sqlsrv php73.extensions.sqlsrv php74.extensions.sqlsrv

@talyz
Copy link
Contributor

talyz commented Apr 15, 2020

Yeah, the error message is sadly pretty cryptic, since it originates in strings-with-deps.nix. We should try to catch it earlier and say something a bit more informational than attribute xxx missing..

@nixos-discourse
Copy link

nixos-discourse commented Apr 17, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/17

@aanderse aanderse force-pushed the aanderse:msphpsql branch from f8668cf to 6cb5dcb May 3, 2020
@ofborg ofborg bot requested review from talyz, globin and Ma27 May 3, 2020
@aanderse
Copy link
Contributor Author

aanderse commented May 3, 2020

@GrahamcOfBorg build php72.extensions.pdo_sqlsrv php73.extensions.pdo_sqlsrv php74.extensions.pdo_sqlsrv
@GrahamcOfBorg build php72.extensions.sqlsrv php73.extensions.sqlsrv php74.extensions.sqlsrv

@aanderse aanderse force-pushed the aanderse:msphpsql branch from 6cb5dcb to 9eb139b May 3, 2020
@aanderse
Copy link
Contributor Author

aanderse commented May 3, 2020

I don't have a mac so can't effectively troubleshoot the issue... 🤷‍♂️

Look good @etu and @talyz?

@talyz
Copy link
Contributor

talyz commented May 3, 2020

@aanderse It builds just fine in my mac, so whatever the build error was, it was probably just a CI glitch - they seem rather frequent on darwin..

@aanderse aanderse force-pushed the aanderse:msphpsql branch from 9eb139b to 88979ff May 3, 2020
@aanderse
Copy link
Contributor Author

aanderse commented May 3, 2020

In that case I'm merging based on your feedback 👍
Thank you @talyz 🎉

@aanderse aanderse merged commit dc05d93 into NixOS:master May 3, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="88979ff"; rev="88979ff3aa31e6e997981fb953ad0c02c078e3a2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="88979ff"; rev="88979ff3aa31e6e997981fb953ad0c02c078e3a2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="88979ff"; rev="88979ff3aa31e6e997981fb953ad0c02c078e3a2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="88979ff"; rev="88979ff3aa31e6e997981fb953ad0c02c078e3a2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="88979ff"; rev="88979ff3aa31e6e997981fb953ad0c02c078e3a2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="88979ff"; rev="88979ff3aa31e6e997981fb953ad0c02c078e3a2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="88979ff"; rev="88979ff3aa31e6e997981fb953ad0c02c078e3a2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@aanderse aanderse deleted the aanderse:msphpsql branch May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.