Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ygor: init at 20200415.1 #85339

Closed
wants to merge 2 commits into from
Closed

Ygor: init at 20200415.1 #85339

wants to merge 2 commits into from

Conversation

@hdclark
Copy link

@hdclark hdclark commented Apr 16, 2020

Initial packaging in preparation for forthcoming application.

Motivation for this change

Initial packaging for this support library is requested in preparation for a forthcoming application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Initial packaging in preparation for forthcoming application.
pkgs/development/libraries/ygor/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@wamserma wamserma left a comment

LGTM.

@stale
Copy link

@stale stale bot commented Oct 14, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@wamserma
Copy link
Contributor

@wamserma wamserma commented Oct 15, 2020

@hdclark I see you are still actively working on this project. Maybe update this PR to the most recent version.
However, since this is currently not relevant for a wider audience and thus may not get the attention you expect from a maintainer (e.g. long time-to-merge), it may be easier to put it in your own NUR - setup is easy thanks to the provided template.

@stale stale bot removed the 2.status: stale label Oct 15, 2020
@hdclark
Copy link
Author

@hdclark hdclark commented Oct 16, 2020

@wamserma Good idea, thanks. I wasn't aware of NUR packaging and I think it fits this library better than nixpkgs at the moment.

@hdclark hdclark closed this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants