Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: 7.4.4 -> 7.4.5, 7.3.16 -> 7.3.17 #85427

Closed
wants to merge 2 commits into from
Closed

php: 7.4.4 -> 7.4.5, 7.3.16 -> 7.3.17 #85427

wants to merge 2 commits into from

Conversation

@etu
Copy link
Contributor

etu commented Apr 17, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
etu added 2 commits Apr 15, 2020
@etu
Copy link
Contributor Author

etu commented Apr 17, 2020

@GrahamcOfBorg build php73 php74
@GrahamcOfBorg nixosTests.php

Copy link
Member

Ma27 left a comment

@etu while it's building and working fine on my machine, darwin and aarch64 seem to break because of this update. Could you take a look, please? :)

@FRidh FRidh added this to the 20.09 milestone May 1, 2020
@ajs124
Copy link
Member

ajs124 commented May 15, 2020

What's the status on this? There also seems to be a merge conflict, now.

@etu etu closed this May 15, 2020
@etu
Copy link
Contributor Author

etu commented May 15, 2020

@ajs124 For easier testing and being able to merge the different versions independent of each other I've fixed the conflicts and will open separate PR's.

@etu etu deleted the etu:php-updates branch May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.