Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crystal: use llvm 10 exclusively #85445

Merged
merged 5 commits into from May 7, 2020
Merged

crystal: use llvm 10 exclusively #85445

merged 5 commits into from May 7, 2020

Conversation

@manveru
Copy link
Contributor

manveru commented Apr 17, 2020

Motivation for this change

This is trying to fix build failures on darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@manveru manveru marked this pull request as draft Apr 17, 2020
@ofborg ofborg bot requested review from david50407 and peterhoeg Apr 17, 2020
peterhoeg and others added 2 commits Mar 18, 2020
This reverts commit 2ec0ad5.
@manveru manveru marked this pull request as ready for review Apr 18, 2020
@manveru
Copy link
Contributor Author

manveru commented Apr 18, 2020

So far this has been working well for me, Ideally I'd always like to use the latest version of LLVM, but there's no good alias available.
For now we can update it manually (if I don't forget about it).

Since we always depend on LLVM anyway, I don't think we should use a different stdenv at all.

@peterhoeg

@@ -108,6 +108,8 @@ let
"all" "docs"
];

LLVM_CONFIG = "${llvm}/bin/llvm-config";

This comment has been minimized.

Copy link
@peterhoeg

peterhoeg Apr 19, 2020

Member

Are you sure this is necessary? Crystal should be handling this for us.

This comment has been minimized.

Copy link
@peterhoeg

peterhoeg Apr 22, 2020

Member

Ahh, but we still need it for the old versions. Doh.

@manveru manveru force-pushed the manveru:crystal-all-llvm branch from 5eb607b to 164dfe4 Apr 20, 2020
@ofborg ofborg bot requested a review from peterhoeg Apr 20, 2020
@peterhoeg
Copy link
Member

peterhoeg commented Apr 22, 2020

I cannot help with the testing on mac but when #83054 lands, it'll be easy to check all the dependents on linux at least.

@manveru
Copy link
Contributor Author

manveru commented Apr 23, 2020

@peterhoeg i have access to a few macs for testing this, and it seems perfectly fine so far. Wonder if we can whitelist aarch64 as well now :)

@peterhoeg
Copy link
Member

peterhoeg commented Apr 23, 2020

@grahamc grahamc merged commit fb587d7 into NixOS:master May 7, 2020
16 checks passed
16 checks passed
crystal, crystal.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
crystal, crystal.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="164dfe4"; rev="164dfe4b44de535b6674647255de25bfc6a6e8d1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="164dfe4"; rev="164dfe4b44de535b6674647255de25bfc6a6e8d1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="164dfe4"; rev="164dfe4b44de535b6674647255de25bfc6a6e8d1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="164dfe4"; rev="164dfe4b44de535b6674647255de25bfc6a6e8d1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="164dfe4"; rev="164dfe4b44de535b6674647255de25bfc6a6e8d1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="164dfe4"; rev="164dfe4b44de535b6674647255de25bfc6a6e8d1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="164dfe4"; rev="164dfe4b44de535b6674647255de25bfc6a6e8d1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.