Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nat: substitute iptables for compat under nftables #85462

Closed
wants to merge 1 commit into from

Conversation

@bqv
Copy link
Contributor

bqv commented Apr 17, 2020

(Migrated from #84949 due to a wonderful demonstration of PEBKAC)

Motivation for this change

Currently, NAT will not work if you have nftables enabled (and therefore default firewall disabled (and therefore ip_tables unloaded/blacklisted)). This allows those using nftables to enable nat and have it work with minimal code change, thanks to the good work of those who created iptables-nftables-compat.

Debugging why my containers had no network access was a pain, this change fixed my issue, I'm using it right now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bqv bqv force-pushed the bqv:nat-nftables branch from 7579090 to bc0ded6 Apr 18, 2020
@bqv bqv requested a review from misuzu Apr 18, 2020
nixos/modules/services/networking/nat.nix Outdated Show resolved Hide resolved
@bqv bqv force-pushed the bqv:nat-nftables branch from bc0ded6 to ebcbea5 Apr 18, 2020
@misuzu
misuzu approved these changes Apr 18, 2020
@nixos-discourse
Copy link

nixos-discourse commented May 4, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/145

@bqv
Copy link
Contributor Author

bqv commented May 19, 2020

closing not because it's solved, but because no activity and I don't really care enough to keep pushing.

@bqv bqv closed this May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.