Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: unbreak typerep-map, co-log and co-log-sys #85486

Closed
wants to merge 0 commits into from

Conversation

@poscat0x04
Copy link
Contributor

poscat0x04 commented Apr 18, 2020

Motivation for this change

Fix broken packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@poscat0x04
Copy link
Contributor Author

poscat0x04 commented Apr 18, 2020

by the way, unbreaking by disabling tests is very mechanical and can be easily automated

# Test suits dependencies are outdated
typerep-map = dontCheck super.typerep-map;

# Test suites are not implemented

This comment has been minimized.

Copy link
@cdepillabout

cdepillabout Apr 18, 2020

Member

What does this comment mean?

This comment has been minimized.

Copy link
@poscat0x04

poscat0x04 Apr 18, 2020

Author Contributor

typerep-map's test suite failed because dependencies could not be satisfied (QuichCheck etc. are out-dated)
co-log-sys's test suite failed because it uses IO while also enables NoImplicitPrelude.

@poscat0x04 poscat0x04 force-pushed the poscat0x04:haskell-updates branch from c2943c4 to 6d9922a Apr 18, 2020
# Test suite's dependencies (QuickCheck etc.) are outdated
typerep-map = dontCheck super.typerep-map;

# Test suite is broken (uses IO while enables NoImplicitPrelude at the same time)

This comment has been minimized.

Copy link
@cdepillabout

cdepillabout Apr 18, 2020

Member

Could you report this problem upstream, and then link to it in this comment here in the code?

We'd like to easily be able to know when we can remove these types of overrides.

This comment has been minimized.

Copy link
@poscat0x04
@@ -1507,6 +1507,14 @@ self: super: {
# Fixed at head, but hasn't cut a release in awhile.
darcs = doJailbreak super.darcs;

# Test suite's dependencies (QuickCheck etc.) are outdated
# see https://github.com/kowainik/typerep-map/issues/81

This comment has been minimized.

Copy link
@vrom911

vrom911 Apr 18, 2020

This issue was resolved. New typerep-map-0.3.3.0 has been released on Hackage.

@@ -3637,8 +3637,6 @@ broken-packages:
- cmt
- cmv
- cnc-spec-compiler
- co-log

This comment has been minimized.

Copy link
@chshersh
@peti peti force-pushed the NixOS:haskell-updates branch 4 times, most recently from 50d38e7 to e567a3b Apr 24, 2020
@peti peti changed the base branch from haskell-updates to master May 1, 2020
@peti peti changed the base branch from master to haskell-updates May 1, 2020
@peti peti force-pushed the NixOS:haskell-updates branch 4 times, most recently from d8e9519 to 1d4449c May 1, 2020
@poscat0x04 poscat0x04 force-pushed the poscat0x04:haskell-updates branch from 7418858 to d990ff9 May 2, 2020
@cdepillabout
Copy link
Member

cdepillabout commented May 5, 2020

@poscat0x04 What's the status of this? Can it be closed, or are you still working on it?

@poscat0x04 poscat0x04 closed this May 5, 2020
@poscat0x04 poscat0x04 force-pushed the poscat0x04:haskell-updates branch from d990ff9 to f617f24 May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.