Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: use https for nixos.org and hydra.nixos.org #85516

Merged
merged 1 commit into from May 4, 2020

Conversation

@prusnak
Copy link
Member

prusnak commented Apr 18, 2020

Motivation for this change

Let's use https for nixos.org and hydra.nixos.org.

tarballs.nixos.org is omitted from the change because urls from there are always hashed and checked

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
tarballs.nixos.org is omitted from the change because urls from there
are always hashed and checked
@iblech
Copy link
Contributor

iblech commented Apr 19, 2020

Thank you for your efforts! Very appreciated.

tarballs.nixos.org is omitted from the change because urls from there are always hashed and checked

We still leak privacy when communicating with tarballs.nixos.org over http, even if the connection cannot be tampered with because we are verifying the hashes. Hence personally I'd even support a pull request which changes also these. But the current pull request is a great start!

@prusnak
Copy link
Member Author

prusnak commented Apr 19, 2020

@grahamc What do you think? Should we change all URLs from http to https even for the content that's being hashed & verified?

I can imagine there are some reasons why NOT to do it.

Copy link
Contributor

jonringer left a comment

diff LGTM, no objections in 2 weeks

@jonringer jonringer merged commit 7b01672 into NixOS:master May 4, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ad4218"; rev="7ad421875cc053497805f03885f4b35d5b4031dc"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ad4218"; rev="7ad421875cc053497805f03885f4b35d5b4031dc"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ad4218"; rev="7ad421875cc053497805f03885f4b35d5b4031dc"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ad4218"; rev="7ad421875cc053497805f03885f4b35d5b4031dc"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ad4218"; rev="7ad421875cc053497805f03885f4b35d5b4031dc"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ad4218"; rev="7ad421875cc053497805f03885f4b35d5b4031dc"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ad4218"; rev="7ad421875cc053497805f03885f4b35d5b4031dc"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@prusnak prusnak deleted the prusnak:https branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.