Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i3lock-color: 2.12.c.1 -> 2.12.c.2 #85525

Closed
wants to merge 1 commit into from
Closed

Conversation

@eadwu
Copy link
Member

eadwu commented Apr 19, 2020

Mark is_release to be yes so ASAN isn't used

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Mark is_release to be yes so ASAN isn't used
@drewrisinger
Copy link
Contributor

drewrisinger commented Apr 28, 2020

What is ASAN?

Builds locally with nixpkgs-review pr 85525:

https://github.com/NixOS/nixpkgs/pull/85525
3 package built:
betterlockscreen i3lock-color i3lock-fancy

@GrahamcOfBorg build i3lock-color

@eadwu
Copy link
Member Author

eadwu commented Apr 28, 2020

https://clang.llvm.org/docs/AddressSanitizer.html
More of something used in development I believe.

Copy link
Contributor

drewrisinger left a comment

See prev comment for build.

  • Diff LGTM
  • Builds OK
  • Tested locally
@eadwu
Copy link
Member Author

eadwu commented May 21, 2020

#88149

I'll just keep the ASAN override locally since it seems like it isn't a problem as long as someone doesn't use a hardened malloc.

@eadwu eadwu closed this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.