buildGoPackage: use $out instead of $bin

[zowoq]

cc @kalbasit @Mic92

This changes buildGoPackage to use to $out instead of $bin which matches the behaviour of buildGoModule (and buildRustPackage).

nixpkgs/pkgs/servers/sql/cockroachdb/default.nix

Lines 53 to 57 in a2d9f58

	# Unfortunately we have to keep an empty reference to $out, because it seems
	# buildGoPackages only nukes references to the go compiler under $bin, effectively
	# making all binary output under $bin mandatory. Ideally, we would just use
	# $out and $man and remove $bin since there's no point in an empty path. :(
	outputs = [ "bin" "man" "out" ];

[adisbladis]

In #43328 I opted not to do this as it would introduce an incompatibility for questionable gain.

[kalbasit]

Can we alias out to bin for backward compatibility?

[Mic92]

Can we alias out to bin for backward compatibility?

It could be a symlink I think. However I suspect most of the breakages occur in the build expressions itself because $bin needs to be changed to $out.

[kalbasit]

How about deprecate the output (not sure that's possible, at least the trace part), spread the word to give people a couple of months before we do this? In the meantime we could gate the output change with an attr and set it from within nixpkgs.

[zowoq]

I might do another round of $bin cleanup but starting to get to the point of diminishing returns.

I'm not sure how to move forward with this?

[Mic92]

The mkdir in nixpkgs/pkgs/servers/monitoring/uchiwa/default.nix needs a -p.

[zowoq]

It already has -p?

[zowoq]

The other mkdir. Fixed.

[Mic92]

Could you also write a short entry in doc/manual/release-notes/rl-2009.xml. This is a breaking change for all out-of-tree buildGoPackages.

[zowoq]

Added a note and dropped a paragraph from the go docs that referenced defaulting to $bin.

[Mic92]

Merged into staging in 20e67f1