Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whsniff: init #85573

Merged
merged 2 commits into from May 3, 2020
Merged

whsniff: init #85573

merged 2 commits into from May 3, 2020

Conversation

@snicket2100
Copy link
Contributor

snicket2100 commented Apr 19, 2020

Motivation for this change

adding a new package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@snicket2100
Copy link
Contributor Author

snicket2100 commented Apr 19, 2020

labelled it as platforms.linux as I have no way to build it on Darwin... is this all right, or what's the alternative?

@snicket2100 snicket2100 marked this pull request as draft Apr 19, 2020
@snicket2100 snicket2100 force-pushed the snicket2100:whsniff-init branch from 293e6af to 2eaf4a8 Apr 19, 2020
@snicket2100 snicket2100 marked this pull request as ready for review Apr 19, 2020
Copy link
Member

calbrecht left a comment

Build with nixpkgs-review pr and started whsniff in resulting shell.
LGTM, although i cannot tell if it does what it should, since i do not own a TI CC2531 USB Dongle :)

@snicket2100
Copy link
Contributor Author

snicket2100 commented Apr 20, 2020

:) I did test the binary myself with the dongle, works as expected!

@calbrecht
Copy link
Member

calbrecht commented Apr 20, 2020

nixpkgs-review pr 85573
1 package built:
whsniff

@snicket2100 snicket2100 force-pushed the snicket2100:whsniff-init branch from 2eaf4a8 to 9cac9f6 Apr 26, 2020
Copy link
Contributor

jonringer left a comment

the whsniff commit should be whisniff: init at 1.3

@snicket2100 snicket2100 force-pushed the snicket2100:whsniff-init branch from 9cac9f6 to 68d0023 May 3, 2020
@snicket2100
Copy link
Contributor Author

snicket2100 commented May 3, 2020

the whsniff commit should be whisniff: init at 1.3

fixed! @jonringer

Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 85573 1

1 package built: - whsniff

@jonringer jonringer merged commit e91183d into NixOS:master May 3, 2020
15 of 16 checks passed
15 of 16 checks passed
whsniff, whsniff.passthru.tests on aarch64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68d0023"; rev="68d0023b494bce7ece0807a3031aaa8d091336fb"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68d0023"; rev="68d0023b494bce7ece0807a3031aaa8d091336fb"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68d0023"; rev="68d0023b494bce7ece0807a3031aaa8d091336fb"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68d0023"; rev="68d0023b494bce7ece0807a3031aaa8d091336fb"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68d0023"; rev="68d0023b494bce7ece0807a3031aaa8d091336fb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68d0023"; rev="68d0023b494bce7ece0807a3031aaa8d091336fb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68d0023"; rev="68d0023b494bce7ece0807a3031aaa8d091336fb"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
whsniff, whsniff.passthru.tests on x86_64-linux Success
Details
@snicket2100 snicket2100 deleted the snicket2100:whsniff-init branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.