Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger-live-desktop: 2.1.0 -> 2.3.2 #85646

Merged
merged 2 commits into from May 12, 2020
Merged

Conversation

@nyanloutre
Copy link
Member

nyanloutre commented Apr 21, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

pnelson left a comment

Builds and runs fine.

Copy link
Contributor

FelschR left a comment

v2.3.2 has been released.

Co-authored-by: Felix Tenley <felschr@gmail.com>
@nyanloutre nyanloutre changed the title ledger-live-desktop: 2.1.0 -> 2.2.4 ledger-live-desktop: 2.1.0 -> 2.3.2 Apr 30, 2020
@FelschR
Copy link
Contributor

FelschR commented May 9, 2020

Builds and runs fine for me.

@nixos-discourse
Copy link

nixos-discourse commented May 9, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/152

@bhipple
Copy link
Contributor

bhipple commented May 12, 2020

Result of nixpkgs-review pr 85646 1

1 package built:
- ledger-live-desktop
@bhipple bhipple merged commit 49540ba into NixOS:master May 12, 2020
16 checks passed
16 checks passed
ledger-live-desktop, ledger-live-desktop.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="11a9fbe"; rev="11a9fbe5283987ae740dfde14df885d84e088445"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="11a9fbe"; rev="11a9fbe5283987ae740dfde14df885d84e088445"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="11a9fbe"; rev="11a9fbe5283987ae740dfde14df885d84e088445"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="11a9fbe"; rev="11a9fbe5283987ae740dfde14df885d84e088445"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="11a9fbe"; rev="11a9fbe5283987ae740dfde14df885d84e088445"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="11a9fbe"; rev="11a9fbe5283987ae740dfde14df885d84e088445"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="11a9fbe"; rev="11a9fbe5283987ae740dfde14df885d84e088445"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ledger-live-desktop, ledger-live-desktop.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.