Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin.binutils: propagate man pages from darwin.cctools #85653

Merged
merged 4 commits into from May 1, 2020

Conversation

@veprbl
Copy link
Member

veprbl commented Apr 21, 2020

Motivation for this change

Man pages from GNU binutils are too useful for darwin binutils.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
veprbl added 4 commits Apr 20, 2020
…ginal
In the distribution they are located in a separate directory from the
others and the standard installation doesn't process them.
@veprbl veprbl requested a review from Ericson2314 as a code owner Apr 21, 2020
@ofborg ofborg bot added the 6.topic: darwin label Apr 21, 2020
@veprbl veprbl added this to WIP in Staging via automation Apr 21, 2020
@ofborg ofborg bot requested a review from matthewbauer Apr 21, 2020
@matthewbauer
Copy link
Member

matthewbauer commented Apr 21, 2020

This was previously considered in #43547 and the idea was that propagation should be enough to get the man pages. Unsure whether any of that still applies.

@FRidh FRidh moved this from WIP to Needs review in Staging Apr 21, 2020
@veprbl
Copy link
Member Author

veprbl commented Apr 21, 2020

@matthewbauer
That was to do with the common binutils wrapper and in the end symlinks were used. The main purpose of this change is to get the right man pages. The man pages from Apple are better describing bintools from Apple than man pages from the GNU project.

Staging automation moved this from Needs review to Ready Apr 24, 2020
@FRidh FRidh merged commit 2da19f9 into NixOS:staging May 1, 2020
17 checks passed
17 checks passed
darwin.cctools, darwin.cctools.passthru.tests on aarch64-linux No attempt
Details
darwin.cctools, darwin.cctools.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
darwin.cctools, darwin.cctools.passthru.tests on x86_64-darwin Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c00ad79"; rev="c00ad799a084ec2896ebfefff3ae6b31eade49d5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c00ad79"; rev="c00ad799a084ec2896ebfefff3ae6b31eade49d5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c00ad79"; rev="c00ad799a084ec2896ebfefff3ae6b31eade49d5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c00ad79"; rev="c00ad799a084ec2896ebfefff3ae6b31eade49d5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c00ad79"; rev="c00ad799a084ec2896ebfefff3ae6b31eade49d5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c00ad79"; rev="c00ad799a084ec2896ebfefff3ae6b31eade49d5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c00ad79"; rev="c00ad799a084ec2896ebfefff3ae6b31eade49d5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from Ready to Done May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.