Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: add bool type to enable options, or make use of mkEnableOption [20.03 backport] #85674

Merged
merged 1 commit into from Apr 23, 2020

Conversation

@xaverdh
Copy link
Contributor

xaverdh commented Apr 21, 2020

Backport of #85628

Add missing type information to manually specified enable options or replace them by mkEnableOption where appropriate.
@xaverdh xaverdh requested review from peti and thoughtpolice as code owners Apr 21, 2020
@xaverdh xaverdh changed the title treewide: add bool type to enable options, or make use of mkEnableOption treewide: add bool type to enable options, or make use of mkEnableOption [20.03 backport] Apr 22, 2020
@Mic92 Mic92 merged commit 8a966ce into NixOS:release-20.03 Apr 23, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="33d12d7"; rev="33d12d781e245092f19b78fc701ffef6263cfe0c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="33d12d7"; rev="33d12d781e245092f19b78fc701ffef6263cfe0c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="33d12d7"; rev="33d12d781e245092f19b78fc701ffef6263cfe0c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="33d12d7"; rev="33d12d781e245092f19b78fc701ffef6263cfe0c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="33d12d7"; rev="33d12d781e245092f19b78fc701ffef6263cfe0c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="33d12d7"; rev="33d12d781e245092f19b78fc701ffef6263cfe0c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="33d12d7"; rev="33d12d781e245092f19b78fc701ffef6263cfe0c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@xaverdh xaverdh deleted the xaverdh:enable-add-type-backport branch Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.