Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init privacyIDEA packages and modules #85687

Merged
merged 9 commits into from May 13, 2020
Merged

Conversation

@globin
Copy link
Member

globin commented Apr 21, 2020

Motivation for this change

Packaging of a generic multi factor authentication system (2FA, MFA, OTP Server) and its accompanying LDAP authentication proxy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • N/A macOS
    • N/A other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @elseym @WilliButz @lheckemann @fpletz @Ma27

globin added 8 commits Apr 13, 2020
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/servers/privacyidea/ldap-proxy.nix Outdated Show resolved Hide resolved
Copy link
Contributor

aanderse left a comment

Just a few things that came to mind. Opinions you're more than welcome to take if you find useful, and ignore if you don't.

nixos/modules/services/security/privacyidea.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/privacyidea.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/privacyidea.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/privacyidea.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/privacyidea.nix Outdated Show resolved Hide resolved
@globin globin force-pushed the mayflower:privacyidea branch from c516ee5 to b64ebef May 8, 2020
@globin
Copy link
Member Author

globin commented May 8, 2020

I think I've addressed all comments except for the python-modules question above, ping @FRidh ?

@globin globin force-pushed the mayflower:privacyidea branch from b64ebef to a21fbca May 8, 2020
@globin
Copy link
Member Author

globin commented May 8, 2020

Updated

@FRidh
FRidh approved these changes May 9, 2020
@globin globin force-pushed the mayflower:privacyidea branch from a21fbca to f1f0e82 May 9, 2020
@lheckemann lheckemann merged commit db010c5 into NixOS:master May 13, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1f0e82"; rev="f1f0e82c509310d169ed6f38889a7b32244154a9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1f0e82"; rev="f1f0e82c509310d169ed6f38889a7b32244154a9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1f0e82"; rev="f1f0e82c509310d169ed6f38889a7b32244154a9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1f0e82"; rev="f1f0e82c509310d169ed6f38889a7b32244154a9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1f0e82"; rev="f1f0e82c509310d169ed6f38889a7b32244154a9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1f0e82"; rev="f1f0e82c509310d169ed6f38889a7b32244154a9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1f0e82"; rev="f1f0e82c509310d169ed6f38889a7b32244154a9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@lheckemann lheckemann deleted the mayflower:privacyidea branch May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.