Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x42-plugins: 20200114 -> 20200411 #85691

Merged
merged 1 commit into from Apr 23, 2020
Merged

x42-plugins: 20200114 -> 20200411 #85691

merged 1 commit into from Apr 23, 2020

Conversation

@magnetophon
Copy link
Member

magnetophon commented Apr 21, 2020

The patchShebangs need to stay. Upstream changed them to /usr/bin/env,
but I forgot that doesn't exist at build time.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
The patchShebangs need to stay. Upstream changed them to /usr/bin/env,
but I forgot that doesn't exist at build time.
@magnetophon magnetophon force-pushed the magnetophon:x42plugins branch from 2ffc881 to b3d4716 Apr 21, 2020
@FRidh
Copy link
Member

FRidh commented Apr 22, 2020

@GrahamcOfBorg build x42-plugins

@FRidh FRidh merged commit d0b9212 into NixOS:master Apr 23, 2020
3 checks passed
3 checks passed
x42-plugins on aarch64-linux No attempt
Details
x42-plugins on x86_64-darwin No attempt
Details
x42-plugins on x86_64-linux Success
Details
@magnetophon magnetophon deleted the magnetophon:x42plugins branch Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.