Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crowbar: init at unstable-2020-04-23 #85797

Merged
merged 1 commit into from May 2, 2020
Merged

Conversation

@Pamplemousse
Copy link
Member

Pamplemousse commented Apr 22, 2020

Motivation for this change

Bring crowbar to nixpkgs as part of #81418 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Pamplemousse
Copy link
Member Author

Pamplemousse commented Apr 23, 2020

As per @jonringer recommendation, I PRed galkan/crowbar#45 to make the package pip installable.
Waiting for their feedback / merge.

@jonringer
Copy link
Contributor

jonringer commented Apr 23, 2020

if you want, you can include your PR as a patch, and "re-package" this :). I think that would be acceptable

@Pamplemousse Pamplemousse force-pushed the Pamplemousse:crowbar branch 2 times, most recently from f239d73 to d5b82e7 Apr 23, 2020
@Pamplemousse Pamplemousse changed the title crowbar: init at 4.1 crowbar: init at unstable-2020-04-23 Apr 23, 2020
@Pamplemousse
Copy link
Member Author

Pamplemousse commented Apr 23, 2020

@jonringer I am not too sure about what you meant by your comment...

As the PR to upstream has been merged, I updated the one here to unstable-2020-04-23 referencing the latest commit.
However, the "sanity check" triggers a

Traceback (most recent call last):
  File "/nix/store/s2jzaarx2gwbiqgpcxbl7znibafjfrag-crowbar-unstable-2020-04-23/bin/.crowbar-wrapped", line 6, in <module>
    from crowbar import main
ModuleNotFoundError: No module named 'crowbar'

That I can't reproduce. Did I package crowbar wrong?

@Pamplemousse Pamplemousse force-pushed the Pamplemousse:crowbar branch from d5b82e7 to 1d716b3 Apr 28, 2020
pkgs/tools/security/crowbar/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/crowbar/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/crowbar/default.nix Outdated Show resolved Hide resolved
@Pamplemousse Pamplemousse force-pushed the Pamplemousse:crowbar branch from 1d716b3 to 2d39da6 Apr 28, 2020
Copy link
Contributor

jonringer left a comment

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/85797
1 package built:
crowbar
@jonringer jonringer merged commit 98762e7 into NixOS:master May 2, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
crowbar, crowbar.passthru.tests on aarch64-linux Success
Details
crowbar, crowbar.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d39da6"; rev="2d39da6ab5b0ea3a4fb016e2aa92e8c9024e91ca"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d39da6"; rev="2d39da6ab5b0ea3a4fb016e2aa92e8c9024e91ca"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d39da6"; rev="2d39da6ab5b0ea3a4fb016e2aa92e8c9024e91ca"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d39da6"; rev="2d39da6ab5b0ea3a4fb016e2aa92e8c9024e91ca"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d39da6"; rev="2d39da6ab5b0ea3a4fb016e2aa92e8c9024e91ca"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d39da6"; rev="2d39da6ab5b0ea3a4fb016e2aa92e8c9024e91ca"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d39da6"; rev="2d39da6ab5b0ea3a4fb016e2aa92e8c9024e91ca"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.