Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer test: Fix grub extraConfig syntax #85832

Merged
merged 1 commit into from Apr 23, 2020
Merged

Conversation

@benley
Copy link
Member

benley commented Apr 23, 2020

Motivation for this change

It looks like terminal_output.serial is incorrect, according to the grub documentation:
https://www.gnu.org/software/grub/manual/grub/html_node/Serial-terminal.html

Related PR: #79406

cc @nh2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
It looks like `terminal_output.serial` is incorrect, according to the
grub documentation:

https://www.gnu.org/software/grub/manual/grub/html_node/Serial-terminal.html

Related PR: #79406
@nh2
nh2 approved these changes Apr 23, 2020
Copy link
Contributor

nh2 left a comment

It looks right to me.

It would be interesting to know why this was never noticed.

@edolstra in a65b5ec, was the In the installer test, redirect GRUB output to the serial port. intended for debugging purposes when something went wrong? Do you know whether it ever worked?

@flokli
Copy link
Contributor

flokli commented Apr 23, 2020

I also have a

terminal_input serial console; terminal_output serial console

mostly everywhere, so I doubt this ever worked that way.

@flokli flokli merged commit 06a34e6 into NixOS:master Apr 23, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f09b8be"; rev="f09b8be73dbfd6d25cc7fe8ee2352dfc4751b231"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f09b8be"; rev="f09b8be73dbfd6d25cc7fe8ee2352dfc4751b231"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f09b8be"; rev="f09b8be73dbfd6d25cc7fe8ee2352dfc4751b231"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f09b8be"; rev="f09b8be73dbfd6d25cc7fe8ee2352dfc4751b231"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f09b8be"; rev="f09b8be73dbfd6d25cc7fe8ee2352dfc4751b231"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f09b8be"; rev="f09b8be73dbfd6d25cc7fe8ee2352dfc4751b231"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f09b8be"; rev="f09b8be73dbfd6d25cc7fe8ee2352dfc4751b231"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.