Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfce.xfce4-whiskermenu-plugin: 2.4.3 -> 2.4.4 #85837

Merged
merged 2 commits into from Apr 25, 2020

Conversation

@romildo
Copy link
Contributor

romildo commented Apr 23, 2020

Motivation for this change

Update to version 2.4.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@privateseabass
Copy link
Contributor

privateseabass commented Apr 23, 2020

I built it, "-V" works for versioning, but "-h" shows up
getttext: command not found.
Not sure if it is because i don't have another needed package, but worth mentioning.

@romildo
Copy link
Contributor Author

romildo commented Apr 23, 2020

I built it, "-V" works for versioning, but "-h" shows up
getttext: command not found.
Not sure if it is because i don't have another needed package, but worth mentioning.

Fixed.

@worldofpeace worldofpeace merged commit 9d0b4c0 into NixOS:master Apr 25, 2020
17 checks passed
17 checks passed
xfce.xfce4-whiskermenu-plugin, xfce.xfce4-whiskermenu-plugin.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="59cea9d"; rev="59cea9da66cb3672fc1bcb2ad66329e6df2fb723"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="59cea9d"; rev="59cea9da66cb3672fc1bcb2ad66329e6df2fb723"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="59cea9d"; rev="59cea9da66cb3672fc1bcb2ad66329e6df2fb723"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="59cea9d"; rev="59cea9da66cb3672fc1bcb2ad66329e6df2fb723"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="59cea9d"; rev="59cea9da66cb3672fc1bcb2ad66329e6df2fb723"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="59cea9d"; rev="59cea9da66cb3672fc1bcb2ad66329e6df2fb723"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="59cea9d"; rev="59cea9da66cb3672fc1bcb2ad66329e6df2fb723"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
xfce.xfce4-whiskermenu-plugin, xfce.xfce4-whiskermenu-plugin.passthru.tests on aarch64-linux Success
Details
xfce.xfce4-whiskermenu-plugin, xfce.xfce4-whiskermenu-plugin.passthru.tests on x86_64-linux Success
Details
@romildo romildo deleted the romildo:upd.xfce4-whiskermenu-plugin branch Apr 25, 2020
@vdot0x23
Copy link
Contributor

vdot0x23 commented Jun 30, 2020

Will this get backported to 20.03? It includes a bug fix after all :)

Fixed search delay.

https://docs.xfce.org/panel-plugins/xfce4-whiskermenu-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.