Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix haskellPackages.headed-megaparsec #85847

Conversation

@chrbauer
Copy link
Contributor

@chrbauer chrbauer commented Apr 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@chrbauer chrbauer requested review from cdepillabout and Infinisil as code owners Apr 23, 2020
Copy link
Member

@cdepillabout cdepillabout left a comment

Please rebase these changes on haskell-updates and change the base branch on Github to haskell-updates.

Most Haskell-related PRs should go to the haskell-updates branch.

@cdepillabout cdepillabout self-requested a review Apr 23, 2020
Copy link
Member

@cdepillabout cdepillabout left a comment

Sorry, I didn't actually mean to approve this.

@@ -1523,4 +1523,7 @@ self: super: {
sha256 = "sha256:0xbfhzhzg94b4r5qy5dg1c40liswwpqarrc2chcwgfbfnrmwkfc2";
});

# Depends on selective >= 0.4, but the default of selective is 0.3
headed-megaparsec = addBuildDepend super.headed-megaparsec super.selective_0_4_1;

This comment has been minimized.

@cdepillabout

cdepillabout Apr 24, 2020
Member

I think normally we write this like the following:

  headed-megaparsec = super.headed-megaparsec.override {
    selective = self.selective_0_4_1;
  };

Please fix this up (and make sure it still compiles correctly).

Copy link
Member

@cdepillabout cdepillabout left a comment

See comment

@chrbauer chrbauer force-pushed the chrbauer:fix/haskellPackages.headed-megaparsec branch from 48aebe1 to 8b36372 Apr 24, 2020
@chrbauer chrbauer requested a review from cdepillabout Apr 24, 2020
@peti peti force-pushed the NixOS:haskell-updates branch 4 times, most recently from 50d38e7 to e567a3b Apr 24, 2020
@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Apr 25, 2020

@chrbauer Could you rebase this on haskell-updates again?

@chrbauer chrbauer force-pushed the chrbauer:fix/haskellPackages.headed-megaparsec branch from 8b36372 to 078f3ba Apr 25, 2020
@chrbauer
Copy link
Contributor Author

@chrbauer chrbauer commented Apr 25, 2020

@chrbauer Could you rebase this on haskell-updates again

@cdepillabout it's now rebased again

Copy link
Member

@cdepillabout cdepillabout left a comment

LGTM, thanks for fixing this up!

@cdepillabout cdepillabout merged commit 928f7ed into NixOS:haskell-updates Apr 25, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="078f3ba"; rev="078f3bababd497cea94c17b17cfca230e4c8d53b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="078f3ba"; rev="078f3bababd497cea94c17b17cfca230e4c8d53b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="078f3ba"; rev="078f3bababd497cea94c17b17cfca230e4c8d53b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="078f3ba"; rev="078f3bababd497cea94c17b17cfca230e4c8d53b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="078f3ba"; rev="078f3bababd497cea94c17b17cfca230e4c8d53b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="078f3ba"; rev="078f3bababd497cea94c17b17cfca230e4c8d53b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="078f3ba"; rev="078f3bababd497cea94c17b17cfca230e4c8d53b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.