Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mono: 6.0.0.313 -> 6.8.0.105 #85849

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@nek0
Copy link
Contributor

nek0 commented Apr 23, 2020

Motivation for this change

Version of mono was outdated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@drewrisinger
Copy link
Contributor

drewrisinger commented Apr 28, 2020

Mono builds fine for me, but downstream fsharp41 doesn't (using nixpkgs-review pr 85849).
@GrahamcOfBorg build mono fsharp41

Log of failed ``fsharp41`` build:
[nix-shell:~/.cache/nixpkgs-review/pr-85849]$ nix-store --read-log /nix/store/vl8r0y4092qn5r6cil82zvncjd5vawxl-fsharp-4.1.34.drv | cat
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/g246zrs9p0qzzj82hfjv29j3pjgnfaiy-4.1.34.tar.gz
source root is fsharp-4.1.34
setting SOURCE_DATE_EPOCH to timestamp 1518621182 of file fsharp-4.1.34/tests/xplat/core/FsharpUnitTestProject/iOSFSharpLanguageTests/iOSFSharpLanguageTestsViewController.fs
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
applying patch /nix/store/r0wpijv66z88bhnirm07bwmbisma0xwg-fsharp-IsPathRooted-type-inference.patch
patching file src/scripts/scriptlib.fsx
Hunk #1 succeeded at 92 with fuzz 2.
applying patch /nix/store/yrg50zrsqx86ccyd34536hm800bbqmr7-fsharp-string-switchName.patch
patching file src/scripts/scriptlib.fsx
applying patch /nix/store/26b8mv0r3zlgkani9js5g5kdxmdg989w-fsharp-path-overloads.patch
patching file src/scripts/scriptlib.fsx
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
checking whether make sets $(MAKE)... yes
checking for pkg-config... /nix/store/b5h8lxy474cli3gznif4626v76j0nr1s-pkg-config-0.29.2/bin/pkg-config
configure: "pkg-config: /nix/store/b5h8lxy474cli3gznif4626v76j0nr1s-pkg-config-0.29.2/bin/pkg-config"
configure: "PKG_CONFIG_LIBDIR: "
checking for msbuild... /nix/store/2347ivhznl713nb16a4y105vd8q6xhqj-msbuild-16.3+xamarinxplat.2019.07.26.14.57/bin/msbuild
configure: msbuild: /nix/store/2347ivhznl713nb16a4y105vd8q6xhqj-msbuild-16.3+xamarinxplat.2019.07.26.14.57/bin/msbuild
configure: creating ./config.status
config.status: creating mono/launcher
config.status: creating mono/config.make
configure: WARNING: Prefix to use is not the same as mono's: /nix/store/rvd1fpcnbc4amb8gfnkbrdll9dmkhrmd-fsharp-4.1.34
                Consider using: ./autogen.sh --prefix=/nix/store/27g4pbbnxc9azs2qzgsy2vk44s432xz9-mono-6.8.0.105
@nix { "action": "setPhase", "phase": "buildPhase" }
building
substituteStream(): WARNING: pattern '<FSharpCoreOptSigFiles Include="$(FSharpCoreLkgPath)\FSharp.Core.dll" />' doesn't match anything in file 'src/fsharp/Fsc-proto/Fsc-proto.fsproj'
substituteStream(): WARNING: pattern '<FSharpCoreOptSigFiles Include="$(FSharpCoreLkgPath)\FSharp.Core.optdata" />' doesn't match anything in file 'src/fsharp/Fsc-proto/Fsc-proto.fsproj'
substituteStream(): WARNING: pattern '<FSharpCoreOptSigFiles Include="$(FSharpCoreLkgPath)\FSharp.Core.sigdata" />' doesn't match anything in file 'src/fsharp/Fsc-proto/Fsc-proto.fsproj'
substituteStream(): WARNING: pattern '<FSharpCoreOptSigFiles Include="$(FSharpCoreLkgPath)\FSharp.Core.xml" />' doesn't match anything in file 'src/fsharp/Fsc-proto/Fsc-proto.fsproj'
build flags: SHELL=/nix/store/kgp3vq8l9yb8mzghbw83kyr3f26yqvsz-bash-4.4-p23/bin/bash
make build-proto
make[1]: Entering directory '/build/fsharp-4.1.34'
true
MONO_ENV_OPTIONS= /nix/store/2347ivhznl713nb16a4y105vd8q6xhqj-msbuild-16.3+xamarinxplat.2019.07.26.14.57/bin/msbuild /p:Configuration=Proto /p:TargetDotnetProfile=net40 src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj
Microsoft (R) Build Engine version 16.3.0-ci for Mono
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 04/28/2020 21:30:01.
Project "/build/fsharp-4.1.34/src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj" on node 1 (default targets).
CallFsSrGen:
  Creating directory "obj/Proto/net40/".
  mono /build/fsharp-4.1.34/packages/FSharp.Compiler.Tools.4.1.27/tools/fsi.exe --exec "/build/fsharp-4.1.34/src/scripts/fssrgen.fsx" "/build/fsharp-4.1.34/src/fsharp/FSharp.Build/FSBuild.txt" "obj/Proto/net40/FSBuild.fs"  "obj/Proto/net40/FSBuild.resx" 
/nix/store/kgp3vq8l9yb8mzghbw83kyr3f26yqvsz-bash-4.4-p23/bin/sh : warning : setlocale: LC_ALL: cannot change locale (en_US.UTF-8) [/build/fsharp-4.1.34/src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj]
  
  
/build/fsharp-4.1.34/src/scripts/fssrgen.fsx(334,28): error FS0041: A unique overload for method 'GetFileNameWithoutExtension' could not be determined based on type information prior to this program point. A type annotation may be needed. Candidates: System.IO.Path.GetFileNameWithoutExtension(path: System.ReadOnlySpan<char>) : System.ReadOnlySpan<char>, System.IO.Path.GetFileNameWithoutExtension(path: string) : string [/build/fsharp-4.1.34/src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj]
  
/build/fsharp-4.1.34/src/scripts/fssrgen.targets(29,5): error MSB3073: The command "mono /build/fsharp-4.1.34/packages/FSharp.Compiler.Tools.4.1.27/tools/fsi.exe --exec "/build/fsharp-4.1.34/src/scripts/fssrgen.fsx" "/build/fsharp-4.1.34/src/fsharp/FSharp.Build/FSBuild.txt" "obj/Proto/net40/FSBuild.fs"  "obj/Proto/net40/FSBuild.resx" " exited with code 1. [/build/fsharp-4.1.34/src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj]
Done Building Project "/build/fsharp-4.1.34/src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj" (default targets) -- FAILED.

Build FAILED.

"/build/fsharp-4.1.34/src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj" (default target) (1) ->
(CallFsSrGen target) -> 
  /nix/store/kgp3vq8l9yb8mzghbw83kyr3f26yqvsz-bash-4.4-p23/bin/sh : warning : setlocale: LC_ALL: cannot change locale (en_US.UTF-8) [/build/fsharp-4.1.34/src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj]


"/build/fsharp-4.1.34/src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj" (default target) (1) ->
(CallFsSrGen target) -> 
  /build/fsharp-4.1.34/src/scripts/fssrgen.fsx(334,28): error FS0041: A unique overload for method 'GetFileNameWithoutExtension' could not be determined based on type information prior to this program point. A type annotation may be needed. Candidates: System.IO.Path.GetFileNameWithoutExtension(path: System.ReadOnlySpan<char>) : System.ReadOnlySpan<char>, System.IO.Path.GetFileNameWithoutExtension(path: string) : string [/build/fsharp-4.1.34/src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj]
  /build/fsharp-4.1.34/src/scripts/fssrgen.targets(29,5): error MSB3073: The command "mono /build/fsharp-4.1.34/packages/FSharp.Compiler.Tools.4.1.27/tools/fsi.exe --exec "/build/fsharp-4.1.34/src/scripts/fssrgen.fsx" "/build/fsharp-4.1.34/src/fsharp/FSharp.Build/FSBuild.txt" "obj/Proto/net40/FSBuild.fs"  "obj/Proto/net40/FSBuild.resx" " exited with code 1. [/build/fsharp-4.1.34/src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj]

    1 Warning(s)
    2 Error(s)

Time Elapsed 00:00:02.06
make[1]: *** [Makefile:17: build-proto] Error 1
make[1]: Leaving directory '/build/fsharp-4.1.34'
make: *** [Makefile:13: all] Error 2
@nek0
Copy link
Contributor Author

nek0 commented Apr 28, 2020

Ok. I tried to build fsharp, which defaults to the same version on my branch as fsharp41in nixpkgs -unstable, and can confirm failure to build with the same error message.

What I fail to see is, what I can do about it now...

@drewrisinger
Copy link
Contributor

drewrisinger commented Apr 29, 2020

pinging fsharp maintainers @thoughtpolice @7c6f434c

@7c6f434c
Copy link
Member

7c6f434c commented Apr 30, 2020

I wonder if a blind update to 4.5.0 would help (I haven't run F# for some time now)… Or maybe the correct choice is marking as broken pending the update to 10.x.y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.