Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kibi: init at 0.2.0 #85852

Open
wants to merge 1 commit into
base: master
from
Open

kibi: init at 0.2.0 #85852

wants to merge 1 commit into from

Conversation

@robertodr
Copy link
Contributor

robertodr commented Apr 23, 2020

Things done

Added the kibi editor

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

drewrisinger left a comment

Few formatting fixes, otherwise diff LGTM

Builds fine via nixpkgs-review pr 85852

https://github.com/NixOS/nixpkgs/pull/85852
1 package built:
kibi
pkgs/applications/editors/kibi/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/kibi/default.nix Outdated Show resolved Hide resolved
@drewrisinger
Copy link
Contributor

drewrisinger commented Apr 28, 2020

@GrahamcOfBorg build kibi

Copy link
Contributor

drewrisinger left a comment

Builds locally.
Commits need squashed before merging.

nixpkgs-review pr 85852

https://github.com/NixOS/nixpkgs/pull/85852
1 package built:
kibi
@robertodr robertodr force-pushed the robertodr:init-kibi branch from 64ac1bf to ba1daaa Apr 29, 2020
@robertodr robertodr force-pushed the robertodr:init-kibi branch from ba1daaa to 3c75816 Apr 29, 2020
@robertodr robertodr changed the title kibi: init at 0.1.2 kibi: init at 0.2.0 Apr 29, 2020
@robertodr
Copy link
Contributor Author

robertodr commented Apr 29, 2020

Version 0.2.0 was released in the meantime.

@drewrisinger
Copy link
Contributor

drewrisinger commented Apr 29, 2020

@GrahamcOfBorg build kibi

Copy link
Contributor

drewrisinger left a comment

Builds fine locally & via OfBorg. Commits are fixed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.