Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skypeforlinux: 8.55.0.141 -> 8.56.0.103 #85854

Merged
merged 1 commit into from Apr 25, 2020

Conversation

@emmanuelrosa
Copy link
Contributor

emmanuelrosa commented Apr 23, 2020

Motivation for this change

Update skypeforlinux. Closes #85724

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer
Copy link
Contributor

jonringer commented Apr 23, 2020

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

also, you should be targeting release-20.03

@mmilata mmilata mentioned this pull request Apr 23, 2020
4 of 10 tasks complete
Cherry-picked 36c7dc2
Original commit merged in PR #83355
@worldofpeace worldofpeace merged commit 4786f8e into NixOS:release-20.03 Apr 25, 2020
16 checks passed
16 checks passed
skypeforlinux, skypeforlinux.passthru.tests on aarch64-linux No attempt
Details
skypeforlinux, skypeforlinux.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08630e5"; rev="08630e56d9648c6829f8855b117544dcc1c7eb19"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08630e5"; rev="08630e56d9648c6829f8855b117544dcc1c7eb19"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08630e5"; rev="08630e56d9648c6829f8855b117544dcc1c7eb19"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08630e5"; rev="08630e56d9648c6829f8855b117544dcc1c7eb19"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08630e5"; rev="08630e56d9648c6829f8855b117544dcc1c7eb19"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08630e5"; rev="08630e56d9648c6829f8855b117544dcc1c7eb19"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08630e5"; rev="08630e56d9648c6829f8855b117544dcc1c7eb19"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@emmanuelrosa emmanuelrosa deleted the emmanuelrosa:skype-dep-8.56 branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.