Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx: update to 1.18.0 #85856

Merged
merged 2 commits into from Apr 24, 2020
Merged

nginx: update to 1.18.0 #85856

merged 2 commits into from Apr 24, 2020

Conversation

@Izorkin
Copy link
Contributor

Izorkin commented Apr 23, 2020

Motivation for this change

Update nginxStable and ngiunxMainline to 1.18.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 23, 2020

@GrahamcOfBorg test nginx nginx-etag nginx-pubhtml nginx-sso

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 23, 2020

@jtojnar
Copy link
Contributor

jtojnar commented Apr 24, 2020

Changes looking fine: https://nginx.org/en/CHANGES-1.18

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 24, 2020

@GrahamcOfBorg test nginx nginx-etag nginx-pubhtml nginx-sso nghttpx

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 24, 2020

@GrahamcOfBorg test nghttpx

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 24, 2020

@GrahamcOfBorg build nginxStable nginxMainline

@flokli
Copy link
Contributor

flokli commented Apr 24, 2020

Ran some tests locally as well. Let's merge this in - thanks!

@flokli flokli merged commit 6e89b44 into NixOS:master Apr 24, 2020
24 of 26 checks passed
24 of 26 checks passed
nginxMainline, nginxMainline.passthru.tests, nginxStable, nginxStable.passthru.tests on x86_64-linux
Details
tests.nginx, tests.nginx-etag, tests.nginx-pubhtml, tests.nginx-sso on x86_64-linux
Details
tests.nghttpx, tests.nginx, tests.nginx-etag, tests.nginx-pubhtml, tests.nginx-sso on aarch64-linux Failure
Details
tests.nghttpx, tests.nginx, tests.nginx-etag, tests.nginx-pubhtml, tests.nginx-sso on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbfe203"; rev="cbfe203da738f81739a6a1d0b5a22b05bc65b6c9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbfe203"; rev="cbfe203da738f81739a6a1d0b5a22b05bc65b6c9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbfe203"; rev="cbfe203da738f81739a6a1d0b5a22b05bc65b6c9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbfe203"; rev="cbfe203da738f81739a6a1d0b5a22b05bc65b6c9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbfe203"; rev="cbfe203da738f81739a6a1d0b5a22b05bc65b6c9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbfe203"; rev="cbfe203da738f81739a6a1d0b5a22b05bc65b6c9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbfe203"; rev="cbfe203da738f81739a6a1d0b5a22b05bc65b6c9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nginxMainline, nginxMainline.passthru.tests, nginxStable, nginxStable.passthru.tests on aarch64-linux Success
Details
nginxMainline, nginxMainline.passthru.tests, nginxStable, nginxStable.passthru.tests on x86_64-darwin Success
Details
nginxMainline, nginxStable on aarch64-linux Success
Details
nginxMainline, nginxStable on x86_64-darwin Success
Details
nginxMainline, nginxStable on x86_64-linux Success
Details
tests.nghttpx on aarch64-linux Success
Details
tests.nghttpx on x86_64-linux Success
Details
tests.nginx, tests.nginx-etag, tests.nginx-pubhtml, tests.nginx-sso on aarch64-linux Success
Details
@Izorkin Izorkin deleted the Izorkin:nginx-update branch Apr 25, 2020
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Apr 27, 2020
nginx: update to 1.18.0
(cherry picked from commit 6e89b44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.