Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome3.file-roller: 3.36.1 -> 3.36.2 #85865

Merged
merged 1 commit into from Apr 23, 2020
Merged

Conversation

@mmilata
Copy link
Contributor

mmilata commented Apr 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Fixes CVE-2020-11736.
@Mic92
Copy link
Contributor

Mic92 commented Apr 23, 2020

1 similar comment
@jonringer
Copy link
Contributor

jonringer commented Apr 23, 2020

Copy link
Contributor

jtojnar left a comment

Changes look okay and seems to work. Thanks.

@jtojnar jtojnar merged commit 5b49b43 into NixOS:master Apr 23, 2020
14 of 16 checks passed
14 of 16 checks passed
gnome3.file-roller, gnome3.file-roller.passthru.tests on aarch64-linux
Details
gnome3.file-roller, gnome3.file-roller.passthru.tests on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2108f1a"; rev="2108f1aa34aa219bd6a75a1faef59988b2f4ead1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2108f1a"; rev="2108f1aa34aa219bd6a75a1faef59988b2f4ead1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2108f1a"; rev="2108f1aa34aa219bd6a75a1faef59988b2f4ead1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2108f1a"; rev="2108f1aa34aa219bd6a75a1faef59988b2f4ead1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2108f1a"; rev="2108f1aa34aa219bd6a75a1faef59988b2f4ead1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2108f1a"; rev="2108f1aa34aa219bd6a75a1faef59988b2f4ead1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2108f1a"; rev="2108f1aa34aa219bd6a75a1faef59988b2f4ead1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@mmilata mmilata deleted the mmilata:file-roller-3.36.2 branch Apr 23, 2020
@mmilata
Copy link
Contributor Author

mmilata commented Apr 23, 2020

@jtojnar thanks for merging - want me to backport this to 20.03?

@jtojnar
Copy link
Contributor

jtojnar commented Apr 23, 2020

20.03 is stuck on GNOME 3.34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.