Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go tools/linters/language servers #85868

Merged
merged 10 commits into from Apr 24, 2020
Merged

Update go tools/linters/language servers #85868

merged 10 commits into from Apr 24, 2020

Conversation

@Mic92
Copy link
Contributor

Mic92 commented Apr 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Mic92 added 10 commits Apr 23, 2020
gometalinter development has stopped. golangci-lint is the replacement
@Mic92 Mic92 requested a review from jonringer as a code owner Apr 23, 2020
@Mic92
Copy link
Contributor Author

Mic92 commented Apr 23, 2020

1 similar comment
@Mic92
Copy link
Contributor Author

Mic92 commented Apr 23, 2020

@Mic92 Mic92 requested review from kalbasit, vdemeester and adisbladis Apr 23, 2020
@jonringer
Copy link
Contributor

jonringer commented Apr 23, 2020

@ofborg ofborg bot requested a review from jagajaga Apr 23, 2020
@Mic92 Mic92 merged commit 2bba291 into NixOS:master Apr 24, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gocode, gocode.passthru.tests, godef, godef.passthru.tests, gogetdoc, gogetdoc.passthru.tests, gomodifytags, gomodifytags.passthru.tests, gopkgs, gopkgs.passthru.tests, gopls, gopls.passthru.tests, gotools, gotools.passthru.tests, impl, impl.passthru.tests, reftools, reftools.passthru.tests on aarch64-linux Success
Details
gocode, gocode.passthru.tests, godef, godef.passthru.tests, gogetdoc, gogetdoc.passthru.tests, gomodifytags, gomodifytags.passthru.tests, gopkgs, gopkgs.passthru.tests, gopls, gopls.passthru.tests, gotools, gotools.passthru.tests, impl, impl.passthru.tests, reftools, reftools.passthru.tests on x86_64-darwin Success
Details
gocode, gocode.passthru.tests, godef, godef.passthru.tests, gogetdoc, gogetdoc.passthru.tests, gomodifytags, gomodifytags.passthru.tests, gopkgs, gopkgs.passthru.tests, gopls, gopls.passthru.tests, gotools, gotools.passthru.tests, impl, impl.passthru.tests, reftools, reftools.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="019dc06"; rev="019dc065ee5874eee1ef8f23f5236022843fd8c8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="019dc06"; rev="019dc065ee5874eee1ef8f23f5236022843fd8c8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="019dc06"; rev="019dc065ee5874eee1ef8f23f5236022843fd8c8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="019dc06"; rev="019dc065ee5874eee1ef8f23f5236022843fd8c8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="019dc06"; rev="019dc065ee5874eee1ef8f23f5236022843fd8c8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="019dc06"; rev="019dc065ee5874eee1ef8f23f5236022843fd8c8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="019dc06"; rev="019dc065ee5874eee1ef8f23f5236022843fd8c8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Mic92 Mic92 deleted the Mic92:go-tooling branch Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.