Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mit-scheme: 9.2 -> 10.1.10 #85870

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@toraritte
Copy link

toraritte commented Apr 23, 2020

Motivation for this change

The last update has been in 2014 (to 9.2) but a major new release has came out since then (10.x).

Additional notes from commit:

See discussion at https://discourse.nixos.org/t/6776
but to sum up:

The portable C source and Windows binaries are not
available in the latest MIT Scheme release
(see https://www.gnu.org/software/mit-scheme/release.html )
Warning: Locale seems not configured
hence the option to build from source has been
removed from default.nix. Although there is a
source package included in the release (in lieu of
the portable C source), there is a caveat:

Note that you cannot build a working system from the
source unless you have a working MIT/GNU Scheme
compiler to do the compilation. (This doesn't apply
to the portable C source, which requires only a C
compiler.) This means that if the above binaries
don't work on your system, it is pointless to try
building a custom set of binaries from the source
code.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Ubuntu 18.04.3 LTS)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/gyszp2r7dl84n8sry6k89c1as74b993p-mit-scheme-9.2	 622.7M
/nix/store/906m1g2z7qncvzcplfys4sqxzw3fxay4-mit-scheme-10.1.10	 273.3M
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md. (To the best of my knowledge.)
@jonringer
Copy link
Contributor

jonringer commented Apr 23, 2020

@jonringer
Copy link
Contributor

jonringer commented Apr 23, 2020

please rebase your branch ontop of master, and force push to fix eval:

git pull -r origin/master
git push --force .. ..
@toraritte toraritte force-pushed the toraritte:update-mitscheme branch from 8d95b7a to b9adda6 Apr 24, 2020
@toraritte
Copy link
Author

toraritte commented Apr 24, 2020

Sorry about earlier - was under the impression that I did rebase. Thanks!

The  last update  was  in 2014  (9.2),  but a  major
release came out since (10.x).

See discussion at https://discourse.nixos.org/t/6776
but to sum up:

The portable  C source and Windows  binaries are not
available in the latest MIT Scheme release
(see https://www.gnu.org/software/mit-scheme/release.html )
Warning: Locale seems not configured
hence  the  option  to  build from  source has  been
removed  from  `default.nix`.  Although there  is  a
source package  included in the release  (in lieu of
the portable C source), there is a caveat:

> Note that you cannot build a working system from the
> source  unless you  have  a  working MIT/GNU  Scheme
> compiler to do the  compilation. (This doesn't apply
> to the  portable C source,  which requires only  a C
> compiler.)  This means  that if  the above  binaries
> don't work  on your system,  it is pointless  to try
> building a  custom set  of binaries from  the source
> code.
@toraritte toraritte force-pushed the toraritte:update-mitscheme branch from b9adda6 to 3ff8bb7 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.