Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_*_hardened: index patches by major kernel version #85880

Merged
merged 1 commit into from Apr 24, 2020

Conversation

@emilazy
Copy link
Member

emilazy commented Apr 23, 2020

Motivation for this change

This will avoid breaking the build whenever a non-major kernel update happens. In the update script, we map each kernel version to the latest patch for the latest kernel version less than or equal to what we have packaged.

cc @Mic92 @jonringer

@GrahamcOfBorg test hardened latestKernel.hardened

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This will avoid breaking the build whenever a non-major kernel update
happens. In the update script, we map each kernel version to the latest
patch for the latest kernel version less than or equal to what we
have packaged.
emilazy referenced this pull request Apr 23, 2020
@Mic92
Mic92 approved these changes Apr 23, 2020
@emilazy
Copy link
Member Author

emilazy commented Apr 23, 2020

Not sure why the tests didn't run...

@GrahamcOfBorg test hardened latestKernel.hardened

@jonringer
Copy link
Contributor

jonringer commented Apr 23, 2020

Not sure why the tests didn't run...

ofborg will only run if the attr matches exactly. It doesn't comprehend glob or expansion syntax. https://github.com/NixOS/ofborg#automatic-building

@emilazy
Copy link
Member Author

emilazy commented Apr 23, 2020

I explicitly poked it in the PR message, though; asked on IRC and it turns out the ofborg comment listener had been down for 12 hours :)

Hopefully the queue will get to it before the next kernel version comes out >_> (edit: oh, it already did!)

@Mic92 Mic92 merged commit 16e4b9c into NixOS:master Apr 24, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c1db96"; rev="2c1db9649e66e9399fa572d3bb0da67c6e6e1962"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c1db96"; rev="2c1db9649e66e9399fa572d3bb0da67c6e6e1962"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c1db96"; rev="2c1db9649e66e9399fa572d3bb0da67c6e6e1962"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c1db96"; rev="2c1db9649e66e9399fa572d3bb0da67c6e6e1962"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c1db96"; rev="2c1db9649e66e9399fa572d3bb0da67c6e6e1962"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c1db96"; rev="2c1db9649e66e9399fa572d3bb0da67c6e6e1962"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c1db96"; rev="2c1db9649e66e9399fa572d3bb0da67c6e6e1962"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.hardened, tests.latestKernel.hardened on aarch64-linux Success
Details
tests.hardened, tests.latestKernel.hardened on x86_64-linux Success
Details
@emilazy emilazy deleted the emilazy:linux-hardened-update-resilience branch May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.