Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twitter-color-emoji: 12.1.2 -> 12.1.5 #85889

Merged
merged 1 commit into from Apr 24, 2020

Conversation

@emilazy
Copy link
Member

emilazy commented Apr 23, 2020

Motivation for this change

Twemoji version bump, plus a Fedora patch update to fix emoji size: https://src.fedoraproject.org/rpms/twitter-twemoji-fonts/c/282c789d3742d223968a7ddcae6e65374f6dcae1?branch=master

Didn’t finish building locally because Zopfli is really slow, let’s saddle ofborg with it instead…

cc @jtojnar – out of curiosity, is there any particular reason to keep the ImageMagick → GraphicsMagick patch around, other than keeping close to the Fedora upstream? It seems like the only functional change it had was accidental…

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jtojnar
Copy link
Contributor

jtojnar commented Apr 23, 2020

Hmm, I do not actually remember. Maybe I was not sure if the fedora patch does not also change some other parameters.

@emilazy emilazy force-pushed the emilazy:twitter-color-emoji-12.1.5 branch from 56d19de to 63b70bb Apr 23, 2020
@emilazy
Copy link
Member Author

emilazy commented Apr 23, 2020

Yeah, I'm not wholly confident either (maybe that -extent is doing something?) so I've kept it.

Copy link
Contributor

jtojnar left a comment

  • The package builds (37 min on my laptop).
  • nixosTests.fontconfig-default-fonts succeeds.
@jtojnar jtojnar merged commit 79743fe into NixOS:master Apr 24, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63b70bb"; rev="63b70bb4ef4d1ed7dd3546b039d9bf53c1483075"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63b70bb"; rev="63b70bb4ef4d1ed7dd3546b039d9bf53c1483075"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63b70bb"; rev="63b70bb4ef4d1ed7dd3546b039d9bf53c1483075"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63b70bb"; rev="63b70bb4ef4d1ed7dd3546b039d9bf53c1483075"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63b70bb"; rev="63b70bb4ef4d1ed7dd3546b039d9bf53c1483075"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63b70bb"; rev="63b70bb4ef4d1ed7dd3546b039d9bf53c1483075"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63b70bb"; rev="63b70bb4ef4d1ed7dd3546b039d9bf53c1483075"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
twitter-color-emoji, twitter-color-emoji.passthru.tests on aarch64-linux Success
Details
twitter-color-emoji, twitter-color-emoji.passthru.tests on x86_64-linux Success
Details
@jtojnar
Copy link
Contributor

jtojnar commented Apr 24, 2020

Thanks.

@emilazy emilazy deleted the emilazy:twitter-color-emoji-12.1.5 branch Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.