Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] pythonPackages.stem: unmarked as broken #85896

Closed
wants to merge 1 commit into from

Conversation

@paumr
Copy link
Contributor

paumr commented Apr 23, 2020

The package was marked broken but seems to work on 20.03

Copy link
Member

cole-h left a comment

Already asked in IRC to amend the commit, but one more thing while you're touching this file: Ignore me (:

@paumr paumr force-pushed the paumr:release-20.03 branch from babbe49 to 8a2e53a Apr 24, 2020
@paumr paumr changed the title marked stem as not-broken pythonPackages.stem: unmarked as broken Apr 24, 2020
@drewrisinger
Copy link
Contributor

drewrisinger commented Apr 24, 2020

suggestion: change title to [20.03] ...
@GrahamcOfBorg build python27Packages.stem python37Packages.stem python38Packages.stem

@paumr paumr changed the title pythonPackages.stem: unmarked as broken [20.03] pythonPackages.stem: unmarked as broken Apr 24, 2020
@drewrisinger
Copy link
Contributor

drewrisinger commented Apr 24, 2020

Best as I can tell, it fails on python3.8 due to platform.linux_distribution() being removed on py38 (see ofborg log, relevant line I found):

operating system version...                          failed
module 'platform' has no attribute 'linux_distribution'

If you want to unbreak, you should either patch it or see if there's a new upstream version that works with py38

Copy link
Contributor

drewrisinger left a comment

Should either work on py38 or be disabled on py38.

To work on py38, I suggest adding pythonPackages.distro to build, and then patching the offending line to use distro.linux_distribution()
(e.g. via substituteInPlace FILE_NAME --replace "platform.linux_distribution(" "distro.linux_distribution(")

@drewrisinger
Copy link
Contributor

drewrisinger commented Apr 24, 2020

whoops. Looks like this is a duplicate PR of #85642. That one includes update to 1.8.0. I'd recommend taking that one instead.

@drewrisinger drewrisinger mentioned this pull request Apr 24, 2020
4 of 10 tasks complete
@paumr
Copy link
Contributor Author

paumr commented Apr 25, 2020

whoops. Looks like this is a duplicate PR of #85642. That one includes update to 1.8.0. I'd recommend taking that one instead.

Alright, thanks!
I'll close this PR in favor of #85642

@paumr paumr closed this Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.