Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gitea: add settings option #85904

Merged
merged 1 commit into from May 5, 2020
Merged

nixos/gitea: add settings option #85904

merged 1 commit into from May 5, 2020

Conversation

@aanderse
Copy link
Contributor

aanderse commented Apr 24, 2020

Motivation for this change

#57671

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ping @kolaente is this what you'd like to see?

Copy link
Contributor

kolaente left a comment

Looks great!

@aanderse aanderse requested a review from Infinisil Apr 24, 2020
@Ma27 Ma27 self-requested a review Apr 24, 2020
@Ma27
Ma27 approved these changes Apr 24, 2020
Copy link
Member

Infinisil left a comment

Awesome, looking good!

@aanderse aanderse requested review from etu and srhb Apr 25, 2020
@aanderse
Copy link
Contributor Author

aanderse commented Apr 25, 2020

ping @pvgoran

@aanderse aanderse marked this pull request as ready for review Apr 25, 2020
@aanderse
Copy link
Contributor Author

aanderse commented Apr 27, 2020

@GrahamcOfBorg test gitea.mysql gitea.postgres gitea.sqlite3

@pvgoran
Copy link
Contributor

pvgoran commented Apr 28, 2020

This is a straightforward improvement, I like it. I didn't review the code (only looked at it briefly) and didn't test it, though.

It lacks documentation, though. :) I mean, the description is just a link to another (draft) PR, and that PR is about a specific setting.

@srhb
srhb approved these changes Apr 28, 2020
@aanderse
Copy link
Contributor Author

aanderse commented Apr 29, 2020

I wasn't able to reproduce this error locally. Does anyone have any ideas on that?

@aanderse
Copy link
Contributor Author

aanderse commented May 5, 2020

@GrahamcOfBorg test gitea.mysql
@GrahamcOfBorg test gitea.postgres
@GrahamcOfBorg test gitea.sqlite3

@aanderse
Copy link
Contributor Author

aanderse commented May 5, 2020

I guess the failure was a glitch in the matrix 🤷‍♂️

@aanderse aanderse merged commit 39a0020 into NixOS:master May 5, 2020
22 checks passed
22 checks passed
tests.gitea.mysql, tests.gitea.postgres, tests.gitea.sqlite3 on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="218049c"; rev="218049c5c20847bd97cc32a3508cbf51ef25ed44"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="218049c"; rev="218049c5c20847bd97cc32a3508cbf51ef25ed44"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="218049c"; rev="218049c5c20847bd97cc32a3508cbf51ef25ed44"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="218049c"; rev="218049c5c20847bd97cc32a3508cbf51ef25ed44"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="218049c"; rev="218049c5c20847bd97cc32a3508cbf51ef25ed44"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="218049c"; rev="218049c5c20847bd97cc32a3508cbf51ef25ed44"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="218049c"; rev="218049c5c20847bd97cc32a3508cbf51ef25ed44"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.gitea.mysql on aarch64-linux Success
Details
tests.gitea.mysql on x86_64-linux Success
Details
tests.gitea.mysql, tests.gitea.postgres, tests.gitea.sqlite3 on aarch64-linux Success
Details
tests.gitea.postgres on aarch64-linux Success
Details
tests.gitea.postgres on x86_64-linux Success
Details
tests.gitea.sqlite3 on aarch64-linux Success
Details
tests.gitea.sqlite3 on x86_64-linux Success
Details
@aanderse aanderse deleted the aanderse:gitea branch May 5, 2020
@ciil ciil mentioned this pull request Jun 1, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.