Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm_10: link to the llvm compiler-rt share directory from the wrapper #85925

Merged
merged 1 commit into from Oct 11, 2020

Conversation

@andir
Copy link
Member

@andir andir commented Apr 24, 2020

Motivation for this change

This is required for features such as -fsanitze=cfi that (by default)
load the file …/resource-root/share/cfi_blacklist.txt.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This is required for features such as `-fsanitze=cfi` that (by default)
load the file `…/resource-root/share/cfi_blacklist.txt`.
Copy link
Member

@primeos primeos left a comment

Thanks!

@primeos primeos merged commit 3568e17 into NixOS:master Oct 11, 2020
17 checks passed
primeos pushed a commit that referenced this issue Oct 11, 2020
#100190)

A port of #85925 for LLVM 11 to enable CFI for Chromium.

This is required for features such as `-fsanitize=cfi` that (by default)
load the file `…/resource-root/share/cfi_blacklist.txt`.
primeos added a commit to primeos/nixpkgs that referenced this issue Nov 4, 2020
NixOS#100190)

A port of NixOS#85925 for LLVM 11 to enable CFI for Chromium.

This is required for features such as `-fsanitize=cfi` that (by default)
load the file `…/resource-root/share/cfi_blacklist.txt`.

(cherry picked from commit 03dd1b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants