Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easysnap: changing format for samba shadow_copy2 to work #85939

Closed
wants to merge 1 commit into from

Conversation

@sjau
Copy link
Contributor

sjau commented Apr 24, 2020

Motivation for this change

Samba's Shadow Copy2 allows to easily show the modifications of a file in Windows based on snapshots made. A format change of the easysnap snapshots was required to accomplish that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sjau
Copy link
Contributor Author

sjau commented May 6, 2020

ping

@sjau sjau closed this May 11, 2020
@sjau sjau deleted the sjau:easysnap_20200424 branch May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.