Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elmerfem: init at release-8.4 #85962

Merged
merged 2 commits into from May 2, 2020
Merged

elmerfem: init at release-8.4 #85962

merged 2 commits into from May 2, 2020

Conversation

@Wulfsta
Copy link
Contributor

Wulfsta commented Apr 24, 2020

Motivation for this change

Add Elmer FEM to Science/Physics.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Wulfsta
Copy link
Contributor Author

Wulfsta commented Apr 25, 2020

Cleaned up commits to align with contributing guidelines.

@Wulfsta
Copy link
Contributor Author

Wulfsta commented Apr 25, 2020

@GrahamcOfBorg build elmerfem

@Wulfsta Wulfsta closed this Apr 25, 2020
@Wulfsta Wulfsta force-pushed the Wulfsta:master branch from 24f64b6 to 19b77d4 Apr 25, 2020
@Wulfsta Wulfsta reopened this Apr 25, 2020
@Wulfsta
Copy link
Contributor Author

Wulfsta commented Apr 25, 2020

Split commit and added changes, probably not in the ideal way.

@Wulfsta Wulfsta requested a review from jonringer Apr 25, 2020
@Wulfsta Wulfsta requested a review from jonringer Apr 26, 2020
@jonringer
Copy link
Contributor

jonringer commented Apr 26, 2020

please squash the last two commits:

git reset HEAD^
git add pkgs/
git commit --amend --no-edit
git push .. .. --force
@Wulfsta Wulfsta force-pushed the Wulfsta:master branch from 5953159 to 5bab60c Apr 26, 2020
@Wulfsta
Copy link
Contributor Author

Wulfsta commented Apr 27, 2020

@jonringer Squashed, could you take a look at this when you have a chance? Thanks!

Copy link
Contributor

jonringer left a comment

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/85962
1 package built:
elmerfem
@jonringer jonringer merged commit 5dbc4f7 into NixOS:master May 2, 2020
16 checks passed
16 checks passed
elmerfem, elmerfem.passthru.tests on aarch64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
elmerfem, elmerfem.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bab60c"; rev="5bab60c3942f337c18d0bf9894430160f98a3361"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bab60c"; rev="5bab60c3942f337c18d0bf9894430160f98a3361"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bab60c"; rev="5bab60c3942f337c18d0bf9894430160f98a3361"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bab60c"; rev="5bab60c3942f337c18d0bf9894430160f98a3361"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bab60c"; rev="5bab60c3942f337c18d0bf9894430160f98a3361"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bab60c"; rev="5bab60c3942f337c18d0bf9894430160f98a3361"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bab60c"; rev="5bab60c3942f337c18d0bf9894430160f98a3361"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer
Copy link
Contributor

jonringer commented May 2, 2020

Congrats on your first PR @Wulfsta

Sorry, i was busy :)

@Wulfsta
Copy link
Contributor Author

Wulfsta commented May 2, 2020

@jonringer Thanks, there will be another shortly! And don't apologize, there was no rush!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.