Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluez-alsa: fix installation of D-Bus policy and alsa config #85991

Merged
merged 1 commit into from May 19, 2020

Conversation

@lheckemann
Copy link
Member

lheckemann commented Apr 25, 2020

Motivation for this change

Allow bluez-alsa to run again. The $outs weren't expanded correctly, resulting in installation to a directory named "ut" in the build dir.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Will backport once merged since it's a bugfix.

@Mic92
Copy link
Contributor

Mic92 commented Apr 25, 2020

Result of nixpkgs-review pr 85991 1

1 package built:
- bluez-alsa
@lheckemann lheckemann force-pushed the lheckemann:bluez-alsa-fix-dbus-policy branch from 2af8cd0 to cb071f0 Apr 25, 2020
This allows granting bluez-alsa access to the systemwide D-bus name
@lheckemann lheckemann force-pushed the lheckemann:bluez-alsa-fix-dbus-policy branch from cb071f0 to 3605fc7 Apr 25, 2020
@lheckemann lheckemann merged commit 4b2dc0f into NixOS:master May 19, 2020
17 checks passed
17 checks passed
bluez-alsa, bluez-alsa.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
bluez-alsa, bluez-alsa.passthru.tests on aarch64-linux Success
Details
bluez-alsa, bluez-alsa.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3605fc7"; rev="3605fc7a7902f191592979b232b63f0cec2aa043"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3605fc7"; rev="3605fc7a7902f191592979b232b63f0cec2aa043"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3605fc7"; rev="3605fc7a7902f191592979b232b63f0cec2aa043"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3605fc7"; rev="3605fc7a7902f191592979b232b63f0cec2aa043"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3605fc7"; rev="3605fc7a7902f191592979b232b63f0cec2aa043"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3605fc7"; rev="3605fc7a7902f191592979b232b63f0cec2aa043"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3605fc7"; rev="3605fc7a7902f191592979b232b63f0cec2aa043"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@lheckemann lheckemann deleted the lheckemann:bluez-alsa-fix-dbus-policy branch May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.