Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nixos-installer: use temporary directory on target filesystem #85996

Merged
merged 1 commit into from May 8, 2020

Conversation

@misuzu
Copy link
Contributor

misuzu commented Apr 25, 2020

Motivation for this change

This should fix 'No space left on device' on systems with low amount of RAM when there is a need to build something like Linux kernel.

Also fix #77481

How to test this:

  • boot installer on machine with <=2G of RAM
  • mount filesystems, generate config
  • add this to configuration:
{
  boot.kernelPatches = [ {
    name = "crashdump-config";
    patch = null;
    extraConfig = ''
      CRASH_DUMP y
      DEBUG_INFO y
      PROC_VMCORE y
      LOCKUP_DETECTOR y
      HARDLOCKUP_DETECTOR y
    '';
  } ];
}
  • start nixos-install

Without this patch nix build will fail to unpack kernel sources into /tmp (which is on tmpfs on installation).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Mic92

nix build should store it's temporary files on target filesystem.
This should fix 'No space left on device' on systems
with low amount of RAM when there is a need to build something
like Linux kernel
@misuzu misuzu force-pushed the misuzu:nixos-install-low-memory branch from b425ac7 to 5700232 Apr 25, 2020
@misuzu misuzu marked this pull request as ready for review Apr 25, 2020
@xaverdh
Copy link
Contributor

xaverdh commented Apr 26, 2020

Maybe this should be behind a flag or something?

@misuzu
Copy link
Contributor Author

misuzu commented Apr 26, 2020

Maybe this should be behind a flag or something?

This should be default behavior. Installer should work under any conditions without obscure flags or environment variables.
Temporary directory can still be changed using TMPDIR environment variable by expert users but i don't see much reason to do so.

@Mic92
Mic92 approved these changes Apr 26, 2020
@rasendubi
Copy link
Member

rasendubi commented May 8, 2020

@GrahamcOfBorg test installer

@rasendubi rasendubi merged commit afbab5a into NixOS:master May 8, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5700232"; rev="5700232c3fadd8e5f02f21c5e99753544482b4d4"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5700232"; rev="5700232c3fadd8e5f02f21c5e99753544482b4d4"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5700232"; rev="5700232c3fadd8e5f02f21c5e99753544482b4d4"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5700232"; rev="5700232c3fadd8e5f02f21c5e99753544482b4d4"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5700232"; rev="5700232c3fadd8e5f02f21c5e99753544482b4d4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5700232"; rev="5700232c3fadd8e5f02f21c5e99753544482b4d4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5700232"; rev="5700232c3fadd8e5f02f21c5e99753544482b4d4"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.installer on aarch64-linux Success
Details
tests.installer on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.