Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: 1.42.0 -> 1.43.0 #85997

Merged
merged 1 commit into from May 9, 2020
Merged

rustc: 1.42.0 -> 1.43.0 #85997

merged 1 commit into from May 9, 2020

Conversation

@alyssais
Copy link
Member

alyssais commented Apr 25, 2020

Kept 1.42 around for Thunderbird.

i686-apple-darwin is no longer supported upstream. We could still
support building it, for this one release, since we have the binary
for the previous release, (or bootstrap it for future releases from
Rust 1.42,) but since this release is the one that drops support, I
think it makes sense to do it now. (And probably nobody is using it
anyway.)

I’ve built fd and Thunderbird (with previous Rust) on x86_64. I haven’t been able to try Firefox because of #84283.

So this means I’ll need some help:

  • Test whether Firefox builds on x86_64-linux.
  • Test whether fd builds on x86_64-darwin.
Kept 1.42 around for Thunderbird.

i686-apple-darwin is no longer supported upstream.  We could still
support building it, for this one release, since we have the binary
for the previous release, (or bootstrap it for future releases from
Rust 1.42,) but since this release is the one that drops support, I
think it makes sense to do it now.  (And probably nobody is using it
anyway.)
@Mic92
Copy link
Contributor

Mic92 commented Apr 25, 2020

@GrahamcOfBorg build fd

Copy link
Member

spacekookie left a comment

Builds on 86_64-linux

@FRidh FRidh added this to WIP in Staging via automation Apr 27, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging Apr 27, 2020
@alyssais
Copy link
Member Author

alyssais commented May 8, 2020

Still waiting for somebody to test on Darwin…

Staging automation moved this from Needs review to Ready May 8, 2020
@LnL7
LnL7 approved these changes May 8, 2020
Copy link
Member

LnL7 left a comment

Finished building darwin, forgot to report back. Looks good, however didn't check firefox (unrelated failure) and rustracrd breaks with the update (all platforms).

@alyssais
Copy link
Member Author

alyssais commented May 8, 2020

Awesome, thanks for testing!

@FRidh FRidh merged commit daf032e into NixOS:staging May 9, 2020
19 of 20 checks passed
19 of 20 checks passed
rustc, rustc.passthru.tests on x86_64-darwin
Details
fd on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
fd on aarch64-linux Success
Details
fd on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="854804b"; rev="854804bf77724e6d893b8d3007645123538db2c9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="854804b"; rev="854804bf77724e6d893b8d3007645123538db2c9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="854804b"; rev="854804bf77724e6d893b8d3007645123538db2c9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="854804b"; rev="854804bf77724e6d893b8d3007645123538db2c9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="854804b"; rev="854804bf77724e6d893b8d3007645123538db2c9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="854804b"; rev="854804bf77724e6d893b8d3007645123538db2c9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="854804b"; rev="854804bf77724e6d893b8d3007645123538db2c9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
rustc, rustc.passthru.tests on aarch64-linux Success
Details
rustc, rustc.passthru.tests on x86_64-linux Success
Details
Staging automation moved this from Ready to Done May 9, 2020
@Mic92
Copy link
Contributor

Mic92 commented May 9, 2020

Firefox also built on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.