Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghostscript: fix parallel building #86062

Merged
merged 1 commit into from May 8, 2020
Merged

Conversation

@bennofs
Copy link
Contributor

bennofs commented Apr 26, 2020

The build process of ghostscript has missing dependencies, causing
failures in parallel builds (see hydra build
https://hydra.nixos.org/build/117095669/, reported as ghostscript bug
https://bugs.ghostscript.com/show_bug.cgi?id=702364 here)

@bennofs
Copy link
Contributor Author

bennofs commented Apr 27, 2020

There is now also a patch available from upstream: http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=1b4c3669a20c. Should we include that patch instead of disabling parallel make?

@FRidh
Copy link
Member

FRidh commented Apr 27, 2020

If there's a patch then let's just use it.

@FRidh FRidh added this to Needs review in Staging Apr 27, 2020
@bennofs bennofs force-pushed the bennofs:ghostscript-no-parallel branch from 6871777 to ee00a99 Apr 27, 2020
@bennofs
Copy link
Contributor Author

bennofs commented Apr 27, 2020

@FRidh agreed, changed to use patch

The build process of ghostscript has missing dependencies, causing
failures in parallel builds (see hydra build
https://hydra.nixos.org/build/117095669/, reported as ghostscript bug
https://bugs.ghostscript.com/show_bug.cgi?id=702364 here)
@bennofs bennofs force-pushed the bennofs:ghostscript-no-parallel branch from ee00a99 to 260be73 May 1, 2020
@bennofs
Copy link
Contributor Author

bennofs commented May 1, 2020

Oops, the patch needed to be rebased to our ghostscript version. Build is fixed now.

@bennofs bennofs changed the title ghostscript: disable parallel building ghostscript: fix parallel building May 1, 2020
@jtojnar jtojnar merged commit fc5f0be into NixOS:staging May 8, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
ghostscript, ghostscript.passthru.tests on aarch64-linux Success
Details
ghostscript, ghostscript.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="260be73"; rev="260be737080605eff59664d74665d6230523d7ed"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="260be73"; rev="260be737080605eff59664d74665d6230523d7ed"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="260be73"; rev="260be737080605eff59664d74665d6230523d7ed"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="260be73"; rev="260be737080605eff59664d74665d6230523d7ed"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="260be73"; rev="260be737080605eff59664d74665d6230523d7ed"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="260be73"; rev="260be737080605eff59664d74665d6230523d7ed"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="260be73"; rev="260be737080605eff59664d74665d6230523d7ed"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from Needs review to Done May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.