Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor tweaks to develop on luaPackages.mpack #86075

Merged
merged 2 commits into from May 17, 2020
Merged

minor tweaks to develop on luaPackages.mpack #86075

merged 2 commits into from May 17, 2020

Conversation

@teto
Copy link
Contributor

teto commented Apr 26, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
teto added 2 commits Apr 26, 2020
Repository was moved to an organization.
the luarocks package uses the builtin command and discards the Makefile.
While using the makefile one needs to set some more flags.
@teto
Copy link
Contributor Author

teto commented Apr 27, 2020

@GrahamcOfBorg build neovim-unwrapped

@teto teto merged commit 66c04a1 into NixOS:master May 17, 2020
19 of 20 checks passed
19 of 20 checks passed
neovim-unwrapped on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a3d12e"; rev="9a3d12e2aba4432b53d8ce40bdd8e1cf4d2c6e22"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a3d12e"; rev="9a3d12e2aba4432b53d8ce40bdd8e1cf4d2c6e22"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a3d12e"; rev="9a3d12e2aba4432b53d8ce40bdd8e1cf4d2c6e22"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a3d12e"; rev="9a3d12e2aba4432b53d8ce40bdd8e1cf4d2c6e22"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a3d12e"; rev="9a3d12e2aba4432b53d8ce40bdd8e1cf4d2c6e22"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a3d12e"; rev="9a3d12e2aba4432b53d8ce40bdd8e1cf4d2c6e22"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a3d12e"; rev="9a3d12e2aba4432b53d8ce40bdd8e1cf4d2c6e22"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libmpack, libmpack.passthru.tests, luaPackages.mpack, luaPackages.mpack.passthru.tests on aarch64-linux Success
Details
libmpack, libmpack.passthru.tests, luaPackages.mpack, luaPackages.mpack.passthru.tests on x86_64-darwin Success
Details
libmpack, libmpack.passthru.tests, luaPackages.mpack, luaPackages.mpack.passthru.tests on x86_64-linux Success
Details
neovim-unwrapped on aarch64-linux Success
Details
neovim-unwrapped on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.