Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coq-zorns-lemma: 8.9.0 -> 8.11.0 #86090

Merged
merged 1 commit into from May 8, 2020
Merged

Conversation

@amiloradovsky
Copy link
Contributor

amiloradovsky commented Apr 27, 2020

Motivation for this change

To support building latest Coq Topology library. (It's CI depends on Nixpkgs.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested with nix-build . -A coqPackages_8_11.contribs.zorns-lemma --option sandbox true

@vbgl
Copy link
Contributor

vbgl commented Apr 27, 2020

@GrahamcOfBorg build coqPackages.contribs.zorns-lemma

@vbgl vbgl added the 6.topic: coq label Apr 27, 2020
@amiloradovsky amiloradovsky force-pushed the amiloradovsky:coq-zorns-lemma-8-11-0 branch from a9b805b to dd01f06 Apr 27, 2020
@amiloradovsky
Copy link
Contributor Author

amiloradovsky commented Apr 27, 2020

Forgot to remove versions 8.6-8.9: the latest changes are specifically to make it build with Coq 8.10+ and are breaking the compatibility with prior versions. Now all should be fine.

@vbgl
Copy link
Contributor

vbgl commented Apr 28, 2020

@GrahamcOfBorg build coqPackages_8_10.contribs.zorns-lemma coqPackages_8_11.contribs.zorns-lemma

@amiloradovsky
Copy link
Contributor Author

amiloradovsky commented Apr 28, 2020

OK, now Coq couldn't find GTK+ for CoqIDE.

@vbgl
Copy link
Contributor

vbgl commented Apr 28, 2020

Yes. Gtk is broken: its pkg-config file reads: “Version: 3.24.17” when it should read “3.24.18”.

@vbgl vbgl merged commit 7397d84 into NixOS:master May 8, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
coqPackages_8_10.contribs.zorns-lemma, coqPackages_8_11.contribs.zorns-lemma on aarch64-linux Success
Details
coqPackages_8_10.contribs.zorns-lemma, coqPackages_8_11.contribs.zorns-lemma on x86_64-darwin Success
Details
coqPackages_8_10.contribs.zorns-lemma, coqPackages_8_11.contribs.zorns-lemma on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dd01f06"; rev="dd01f06e4413fc23a94e68e94e6890b146108c37"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dd01f06"; rev="dd01f06e4413fc23a94e68e94e6890b146108c37"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dd01f06"; rev="dd01f06e4413fc23a94e68e94e6890b146108c37"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dd01f06"; rev="dd01f06e4413fc23a94e68e94e6890b146108c37"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dd01f06"; rev="dd01f06e4413fc23a94e68e94e6890b146108c37"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dd01f06"; rev="dd01f06e4413fc23a94e68e94e6890b146108c37"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dd01f06"; rev="dd01f06e4413fc23a94e68e94e6890b146108c37"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.