Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpvScripts.mpris: 0.4 -> 0.5 #86124

Merged
merged 4 commits into from May 6, 2020
Merged

mpvScripts.mpris: 0.4 -> 0.5 #86124

merged 4 commits into from May 6, 2020

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Apr 27, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@doronbehar doronbehar changed the title pistol: 0.0.5 -> 0.1 mpvScripts.mpv: 0.4 -> 0.5 Apr 27, 2020
@Mic92 Mic92 changed the title mpvScripts.mpv: 0.4 -> 0.5 mpvScripts.mpris: 0.4 -> 0.5 Apr 27, 2020
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Apr 27, 2020

@GrahamcOfBorg build mpvScripts.mpris

@doronbehar doronbehar force-pushed the doronbehar:update-mpv-mpris branch from 6ee22e0 to 531104e May 3, 2020
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented May 3, 2020

@GrahamcOfBorg build mpvScripts.mpris

1 similar comment
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented May 3, 2020

@GrahamcOfBorg build mpvScripts.mpris

@doronbehar doronbehar force-pushed the doronbehar:update-mpv-mpris branch 2 times, most recently from 85dccb6 to d4dfb99 May 3, 2020
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented May 3, 2020

Last push is just a git commit --amend fixing the commit messages typos.

@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented May 3, 2020

@GrahamcOfBorg build mpvScripts.mpris

@doronbehar doronbehar force-pushed the doronbehar:update-mpv-mpris branch from d4dfb99 to 28faf5f May 3, 2020
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented May 3, 2020

Damn, I'm not at my best today. Sorry @GrahamcOfBorg but:

@GrahamcOfBorg build mpvScripts.mpris

@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented May 3, 2020

@doronbehar doronbehar force-pushed the doronbehar:update-mpv-mpris branch from 28faf5f to e35ff9e May 3, 2020
@doronbehar doronbehar force-pushed the doronbehar:update-mpv-mpris branch 2 times, most recently from bceeae6 to 595ad51 May 4, 2020
@doronbehar doronbehar force-pushed the doronbehar:update-mpv-mpris branch from 595ad51 to f0e9ed1 May 4, 2020
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented May 5, 2020

ping @Mic92 ?

@doronbehar doronbehar force-pushed the doronbehar:update-mpv-mpris branch from f0e9ed1 to f8367a1 May 6, 2020
Make sure mpris.so is stripped.
mpv-with-scripts: use a standard location for scripts in $out.
mpvScripts.convert: install to the new location of mpv scripts.
Replaced gobject-introspection dependency with glib.
@doronbehar doronbehar force-pushed the doronbehar:update-mpv-mpris branch from f8367a1 to b0ac6a0 May 6, 2020
@jtojnar
jtojnar approved these changes May 6, 2020
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented May 6, 2020

Result of nixpkgs-review pr 86124 1

2 packages built:
- mpvScripts.convert
- mpvScripts.mpris
@Mic92 Mic92 merged commit e3d1f2c into NixOS:master May 6, 2020
1 check was pending
1 check was pending
grahamcofborg-eval Fetching PR
Details
@ofborg ofborg bot requested review from jfrankenau and Profpatsch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.