Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] palemoon: 28.8.4 -> 28.9.1, add GTK3 option #86170

Merged

Conversation

@OPNA2608
Copy link
Contributor

OPNA2608 commented Apr 28, 2020

Backport of PR #86157.

Motivation for this change

New releases came out. Was hoping the update bot would pick up on them like before but it didn't, prolly due to the project moving to a different location.

Things done

Src changed to the new location of the project. Configuration updated based on the current build settings requirements. A GTK3 option has been added as it's now officially sanctioned to be used with the official branding. GTK2 still seems to be the default, but I briefly tested a x86_64 GTK3 build and it seemed to work fine. i686 builds is entirely untested on my end.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    531405504 (28.8.1, haven't updated in awhile) -> 474916144
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
(cherry picked from commit e17bc82)
@ofborg ofborg bot requested a review from AndersonTorres Apr 28, 2020
@AndersonTorres AndersonTorres merged commit 4a04466 into NixOS:release-20.03 May 9, 2020
16 checks passed
16 checks passed
palemoon, palemoon.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffe9bf6"; rev="ffe9bf631155225938ae4cf5975d1b46c11d9624"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffe9bf6"; rev="ffe9bf631155225938ae4cf5975d1b46c11d9624"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffe9bf6"; rev="ffe9bf631155225938ae4cf5975d1b46c11d9624"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffe9bf6"; rev="ffe9bf631155225938ae4cf5975d1b46c11d9624"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffe9bf6"; rev="ffe9bf631155225938ae4cf5975d1b46c11d9624"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffe9bf6"; rev="ffe9bf631155225938ae4cf5975d1b46c11d9624"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffe9bf6"; rev="ffe9bf631155225938ae4cf5975d1b46c11d9624"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
palemoon, palemoon.passthru.tests on x86_64-linux Success
Details
@OPNA2608 OPNA2608 deleted the OPNA2608:backport-update-palemoon branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.