Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdirsyncer: fix build #86210

Merged
merged 2 commits into from May 1, 2020
Merged

vdirsyncer: fix build #86210

merged 2 commits into from May 1, 2020

Conversation

@marsam
Copy link
Contributor

marsam commented Apr 28, 2020

Motivation for this change

https://hydra.nixos.org/build/117749868

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
marsam added 2 commits Apr 28, 2020
@marsam
Copy link
Contributor Author

marsam commented Apr 29, 2020

@GrahamcOfBorg build vdirsyncer vdirsyncerStable

1 similar comment
@marsam
Copy link
Contributor Author

marsam commented Apr 30, 2020

@GrahamcOfBorg build vdirsyncer vdirsyncerStable

@doronbehar
Copy link
Contributor

doronbehar commented May 1, 2020

I also wanted to do that but I wasn't thinking of deselecting these tests like that. Nice 👍. Unfortunately my PR got stale: #85993 :/

Copy link
Contributor

filalex77 left a comment

diff LGTM
nixpkgs-review passed
vdirsyncer --version works

[6 built, 107 copied (338.8 MiB), 71.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/86210
3 packages built:
khal vdirsyncer vdirsyncerStable
@marsam marsam merged commit a8e8f23 into NixOS:master May 1, 2020
19 of 20 checks passed
19 of 20 checks passed
vdirsyncer, vdirsyncer.passthru.tests, vdirsyncerStable, vdirsyncerStable.passthru.tests on x86_64-darwin
Details
vdirsyncer, vdirsyncer.passthru.tests, vdirsyncerStable, vdirsyncerStable.passthru.tests on aarch64-linux Failure
Details
vdirsyncer, vdirsyncerStable on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d6ba1e"; rev="8d6ba1e4232ed84289cbacbf41b2b886d6701fd3"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d6ba1e"; rev="8d6ba1e4232ed84289cbacbf41b2b886d6701fd3"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d6ba1e"; rev="8d6ba1e4232ed84289cbacbf41b2b886d6701fd3"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d6ba1e"; rev="8d6ba1e4232ed84289cbacbf41b2b886d6701fd3"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d6ba1e"; rev="8d6ba1e4232ed84289cbacbf41b2b886d6701fd3"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d6ba1e"; rev="8d6ba1e4232ed84289cbacbf41b2b886d6701fd3"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d6ba1e"; rev="8d6ba1e4232ed84289cbacbf41b2b886d6701fd3"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vdirsyncer, vdirsyncer.passthru.tests, vdirsyncerStable, vdirsyncerStable.passthru.tests on x86_64-linux Success
Details
vdirsyncer, vdirsyncerStable on aarch64-linux Success
Details
vdirsyncer, vdirsyncerStable on x86_64-linux Success
Details
@marsam marsam deleted the marsam:fix-vdirsyncer branch May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.