Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-studio: 25.0.3 -> 25.0.8, use addOpenGLRunpath #86214

Merged
merged 2 commits into from May 17, 2020
Merged

Conversation

@elohmeier
Copy link
Contributor

elohmeier commented Apr 28, 2020

Motivation for this change

OBS was outdated and didn't make use of hardware-accelerated encoders like nvenc (Nvidia).

Things done

Updated to the latest version, added support for nvenc by configuring the addOpenGLRunpath fixup.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@elohmeier elohmeier force-pushed the elohmeier:obs branch from d4ac550 to 36f5598 May 14, 2020
@elohmeier
Copy link
Contributor Author

elohmeier commented May 14, 2020

Restored original formatting to ease reviewing.

@elohmeier
Copy link
Contributor Author

elohmeier commented May 14, 2020

@flokli could you take a look at this PR? It's similar to the ffmpeg PR you've reviewed.

@elohmeier elohmeier force-pushed the elohmeier:obs branch from 36f5598 to a311224 May 17, 2020
@flokli flokli merged commit 0878903 into NixOS:master May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.