Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrtrix: 3.0_RC3_latest -> 3.0.0 #86216

Merged
merged 1 commit into from May 7, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
31 changes: 23 additions & 8 deletions pkgs/applications/science/biology/mrtrix/default.nix
@@ -1,17 +1,17 @@
{ stdenv, lib, fetchFromGitHub, python, makeWrapper
, eigen, fftw, libtiff, zlib, ants, bc
, eigen, fftw, libtiff, libpng, zlib, ants, bc
, qt5, libGL, libGLU, libX11, libXext
, withGui ? true }:

stdenv.mkDerivation rec {
pname = "mrtrix";
version = "3.0_RC3_latest";
version = "3.0.0";

src = fetchFromGitHub {
owner = "MRtrix3";
repo = "mrtrix3";
rev = version;
sha256 = "184nv524p8j94qicjy9l288bqcgl2yxqqs55a7042i0gfsnwp51c";
sha256 = "1vvmmbw3m0bdfwp4szr62ygzsvkj0ss91cx5zlkspsr1rff05f9b";
fetchSubmodules = true;
};

Expand All @@ -22,7 +22,9 @@ stdenv.mkDerivation rec {
python
fftw
libtiff
zlib ] ++ lib.optionals withGui [
libpng
zlib
] ++ lib.optionals withGui [
libGL
libGLU
libX11
Expand All @@ -34,9 +36,14 @@ stdenv.mkDerivation rec {
installCheckInputs = [ bc ];

postPatch = ''
patchShebangs ./build ./configure ./run_tests ./bin/population_template
patchShebangs ./build ./configure ./run_tests ./bin/*

# patching interpreters before fixup is needed for tests:
patchShebangs ./bin/*
patchShebangs testing/binaries/data/vectorstats/*py

substituteInPlace ./run_tests \
--replace 'git submodule update --init >> $LOGFILE 2>&1' ""
--replace 'git submodule update --init $datadir >> $LOGFILE 2>&1' ""
'';

configurePhase = ''
Expand All @@ -50,7 +57,13 @@ stdenv.mkDerivation rec {
(cd testing && ../build)
'';

installCheckPhase = "./run_tests";
installCheckPhase = ''
./run_tests units
./run_tests binaries

# can also `./run_tests scripts`, but this fails due to lack of FSL package
# (and there's no convenient way to disable individual tests)
'';
doInstallCheck = true;

installPhase = ''
Expand All @@ -63,7 +76,9 @@ stdenv.mkDerivation rec {

postInstall = ''
for prog in $out/bin/*; do
wrapProgram $prog --prefix PATH : ${lib.makeBinPath [ ants ]}
if [[ -x "$prog" ]]; then
wrapProgram $prog --prefix PATH : ${lib.makeBinPath [ ants ]}
fi
done
'';

Expand Down