Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcher: 1.5.60 -> 1.5.86 #86228

Merged
merged 1 commit into from May 10, 2020
Merged

etcher: 1.5.60 -> 1.5.86 #86228

merged 1 commit into from May 10, 2020

Conversation

@prusnak
Copy link
Member

prusnak commented Apr 28, 2020

Motivation for this change

Version update.

This also bumps dependency from very old Electron 3 to relatively new Electron 7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested a review from Shou Apr 28, 2020
@prusnak prusnak mentioned this pull request Apr 28, 2020
3 of 10 tasks complete
@prusnak
Copy link
Member Author

prusnak commented Apr 28, 2020

@GrahamcOfBorg build etcher

# We'll use our Nixpkgs electron_3 instead
rm $out/opt/balenaEtcher/balena-etcher-electron
substituteInPlace $out/share/applications/balena-etcher-electron.desktop \
--replace 'Exec=/opt/balenaEtcher/balena-etcher-electron' 'Exec=${pname}'

This comment has been minimized.

Copy link
@Shou

Shou Apr 28, 2020

Contributor

Isn't an absolute path, i.e. $out/bin/etcher safer here?

This comment has been minimized.

Copy link
@prusnak

prusnak Apr 29, 2020

Author Member

Maybe, but the vast majority of desktop files on my system have only relative names in them:

find -name "*.desktop" -type f -exec grep Exec {} \;

Not sure what is the policy in nixpkgs.

@prusnak prusnak force-pushed the prusnak:etcher branch from 19ad6a7 to 7061bcf May 2, 2020
@prusnak prusnak changed the title etcher: 1.5.60 -> 1.5.82 etcher: 1.5.60 -> 1.5.83 May 2, 2020
@ofborg ofborg bot requested a review from Shou May 2, 2020
@Shou
Shou approved these changes May 2, 2020
Copy link
Contributor

Shou left a comment

LGTM

@prusnak prusnak force-pushed the prusnak:etcher branch from 7061bcf to 897a1e6 May 6, 2020
@prusnak prusnak changed the title etcher: 1.5.60 -> 1.5.83 etcher: 1.5.60 -> 1.5.86 May 6, 2020
@ofborg ofborg bot requested a review from Shou May 6, 2020
@mmahut mmahut merged commit 5975bbb into NixOS:master May 10, 2020
17 checks passed
17 checks passed
etcher, etcher.passthru.tests on aarch64-linux No attempt
Details
etcher, etcher.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
etcher, etcher.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897a1e6"; rev="897a1e639380e0178ed457c2e3f03745ab4522c7"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897a1e6"; rev="897a1e639380e0178ed457c2e3f03745ab4522c7"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897a1e6"; rev="897a1e639380e0178ed457c2e3f03745ab4522c7"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897a1e6"; rev="897a1e639380e0178ed457c2e3f03745ab4522c7"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897a1e6"; rev="897a1e639380e0178ed457c2e3f03745ab4522c7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897a1e6"; rev="897a1e639380e0178ed457c2e3f03745ab4522c7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897a1e6"; rev="897a1e639380e0178ed457c2e3f03745ab4522c7"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@prusnak prusnak deleted the prusnak:etcher branch May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.