Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/printers: fix example for hardware.printers.ensurePrinters.*.model #86253

Merged
merged 1 commit into from Jun 20, 2020

Conversation

@erictapen
Copy link
Contributor

erictapen commented Apr 28, 2020

Motivation for this change

The version typo just cost me 30min ;)

nix-repl> lib.version.majorMinor "1.2.3"
error: value is a string while a set was expected, at (string):1:1

nix-repl> lib.versions.majorMinor "1.2.3"
"1.2"
Things done

It's lib.versions, not lib.version. Also I'm really sure that it's supposed to be the current version of Gutenprint, not Cups, as that's what lpinfo -m says on my system (and it works).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
It's `lib.versions`, not `lib.version`. Also I'm really sure that it's
supposed to be the current version of Gutenprint, not Cups, as thats
what `lpinfo -m` says on my system.
Copy link
Contributor

florianjacob left a comment

Both fixes are correct and justified.
I already fixed them in my actual configuration, but forgot that there's the example. :(

@erictapen thanks alot for the fixes, and I'm sorry for the 30 minutes! 🍻

@rnhmjoj rnhmjoj merged commit 34f19a4 into NixOS:master Jun 20, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a77134"; rev="6a7713449fa8016f62eeb5dc8bd66223bd743e4a"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a77134"; rev="6a7713449fa8016f62eeb5dc8bd66223bd743e4a"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a77134"; rev="6a7713449fa8016f62eeb5dc8bd66223bd743e4a"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a77134"; rev="6a7713449fa8016f62eeb5dc8bd66223bd743e4a"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a77134"; rev="6a7713449fa8016f62eeb5dc8bd66223bd743e4a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a77134"; rev="6a7713449fa8016f62eeb5dc8bd66223bd743e4a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a77134"; rev="6a7713449fa8016f62eeb5dc8bd66223bd743e4a"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@erictapen
Copy link
Contributor Author

erictapen commented Jun 20, 2020

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.